Repository navigation
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
2 of 9 tasks
Contributor
🚀 Build Images ReadyImages are ready for commit 2c86cb4. To use with deploy scripts: export MAIN_IMAGE_TAG=5.1.x-464-g2c86cb48ed |
clickboo
force-pushed
the
boo-history-index-migration
branch
from
November 3, 2026 03:10
eea65f1 to
529d383
Compare
2 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## boo-history-index-enrichment #23833 +/- ##
================================================================
- Coverage 52.58% 52.58% -0.01%
================================================================
Files 2836 2838 +2
Lines 178002 178038 +36
================================================================
+ Hits 93606 93613 +7
- Misses 76183 76206 +23
- Partials 8213 8219 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clickboo
force-pushed
the
boo-history-index-enrichment
branch
from
November 3, 2026 18:02
93d97ac to
920c1a5
Compare
clickboo
force-pushed
the
boo-history-index-migration
branch
2 times, most recently
from
November 3, 2026 18:32
caf49d7 to
4f08859
Compare
clickboo
force-pushed
the
boo-history-index-enrichment
branch
from
November 3, 2026 18:32
920c1a5 to
4b8b68e
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
clickboo
force-pushed
the
boo-history-index-migration
branch
from
November 3, 2026 20:25
4f08859 to
2c86cb4
Compare
clickboo
force-pushed
the
boo-history-index-enrichment
branch
from
November 3, 2026 20:25
4b8b68e to
063c029
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Third branch in the max history index stack. Upgrade from sequence 227 to 228 clears
manifest_digestinside eachbase_image_tags.serializedblob. That digest is not its own SQL column. An empty digest makes the next base-image scan treat the tag as unseen, refetch metadata, and store history.History is a new field. Tags written before this stack have none, so upgraded rows stay empty until that refetch. The rewrite only clears the digest and leaves the fields those blobs already had, such as the tag name and layer digests.
base_images.manifestdigestis unchanged. The rollback test now uses a minimum sequence above the current sequence, so the new sequence number does not make the guard look bypassable.Depends on the enrichment branch.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
idandserialized, clears a non-emptyManifestDigest, and writes the blob back.base_image_tagscolumns (id,baseimagerepositoryid,tag,serialized). It seeds a history entry in the blob to check that the rewrite clears only the digest.quickstylepassed on this migration code. The sql integration test was not run here because local Postgres was not up. The previous operator e2e failed onUPDATE ... SET manifestdigest, which this rewrite removes.