Skip to content

fix(be): Compute max history index during enrichment - #23832

Draft
clickboo wants to merge 1 commit into
boo-history-index-protosfrom
boo-history-index-enrichment
Draft

clickboo wants to merge 1 commit into
boo-history-index-protosfrom
boo-history-index-enrichment

Conversation

@clickboo

@clickboo clickboo commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Description

Second branch in the max history index stack. Base image tag fetch now keeps config history, including empty USER, ENV, and CMD lines. Workload enrichment sets max_history_index when that recorded base history is a prefix of a strictly longer child history. The index stays unset when the histories do not line up, so a later Dockerfile-line filter must not cut those images.

This PR records the index. It does not filter policy violations.

Depends on the proto branch. The migration branch is stacked on this one.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • Tag fetcher tests cover history copy, including an empty USER line.
  • Watcher tests cover promotion of that history onto the base image.
  • Enricher tests cover setting max_history_index only for an exact base-history prefix.

@openshift-ci

openshift-ci Bot commented Nov 3, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@clickboo

clickboo commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

This change is part of the following stack:

Change managed by git-spice.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 063c029. To use with deploy scripts:

export MAIN_IMAGE_TAG=5.1.x-463-g063c029bc1

@codecov

codecov Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.58%. Comparing base (56abc9c) to head (063c029).

Additional details and impacted files
@@                      Coverage Diff                      @@
##           boo-history-index-protos   #23832       +/-   ##
=============================================================
+ Coverage                     51.01%   52.58%    +1.57%     
=============================================================
  Files                           793     2836     +2043     
  Lines                         61395   178002   +116607     
=============================================================
+ Hits                          31319    93606    +62287     
- Misses                        26781    76183    +49402     
- Partials                       3295     8213     +4918     
Flag Coverage Δ
go-unit-tests 52.58% <100.00%> (+1.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clickboo
clickboo force-pushed the boo-history-index-enrichment branch from 93d97ac to 920c1a5 Compare November 3, 2026 18:02
@clickboo
clickboo force-pushed the boo-history-index-protos branch from d152951 to 800482b Compare November 3, 2026 18:02
@clickboo
clickboo force-pushed the boo-history-index-enrichment branch from 920c1a5 to 4b8b68e Compare November 3, 2026 18:32
Co-authored-by: Cursor <cursoragent@cursor.com>
@clickboo
clickboo force-pushed the boo-history-index-protos branch from 800482b to 56abc9c Compare November 3, 2026 20:25
@clickboo
clickboo force-pushed the boo-history-index-enrichment branch from 4b8b68e to 063c029 Compare November 3, 2026 20:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant