test(graphql): Add mocked tests for ImageComponent resolver by rhybrillou · Pull Request #21542 · stackrox/stackrox

rhybrillou · 2026-07-03T12:43:57Z

Description

Multiple dependabot pull-requests to upgrade the github.com/graph-gophers/graphql-go failed after the dependency introduced a breaking behaviour change ( see graph-gophers/graphql-go#763 ).

This PR introduces a set of unit tests that helped with the investigation of the upgrade failures.

The pull request is part of a stack:

test(graphql): Add mocked tests for ImageComponent resolver #21542
- tests(graphql): Add interface-implementation method alignment tests #21543
  - refactor: move graphQL resolvers from interface to raw types #21544
    - chore(deps): bump github.com/graph-gophers/graphql-go 1.5.0 -> 1.10.2 #20716
      - chore: revert to GraphQL interface resolvers #21517

User-facing documentation

CHANGELOG.md ~~is updated OR~~ update is not needed
documentation PR ~~is created and is linked above OR~~ is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

added unit tests

How I validated my change

Test-only -> CI run

openshift-ci · 2026-07-03T12:44:00Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-07-03T12:47:52Z

📝 Walkthrough

Summary by CodeRabbit

Tests
- Expanded coverage for image component vulnerability GraphQL queries.
- Verified filtering by CVE and fixable status, including combined filters.
- Confirmed optional query inputs can be omitted and still return valid results.
- Added validation for expected vulnerability details and proper error handling for invalid component IDs.

Walkthrough

Adds a new Go test file for GraphQL image component vulnerability queries. It introduces shared fixtures and mock helpers, then exercises fixable-CVE resolution, filter handling, invalid-component errors, and optional variable behavior.

Changes

Image Component Vulnerability GraphQL Tests

Layer / File(s)	Summary
Test fixtures and query constants `central/graphql/resolvers/image_components_mocked_test.go`	Defines GraphQL query strings and test comments for the image component vulnerability scenarios.
Core GraphQL execution tests `central/graphql/resolvers/image_components_mocked_test.go`	Adds standalone and suite-based tests covering fixable-CVE queries, filter combinations, and invalid component IDs.
Mock setup, validation, and response types `central/graphql/resolvers/image_components_mocked_test.go`	Adds gomock setup, GraphQL response validation helpers, and local response/mock structs used by the tests.

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: mocked GraphQL tests for the ImageComponent resolver.
Description check	✅ Passed	The description follows the template and covers the change, docs, testing, and validation, with only minor incomplete checklist items.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch master-yann/graphql/image_component_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

🧹 Nitpick comments (1)

central/graphql/resolvers/image_components_mocked_test.go (1)
210-292: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Redundant repeated mock setup across subtests.

setupImageComponentCVEMocks is invoked in every t.Run subtest (lines 212, 229, 246, 262), re-registering identical AnyTimes() expectations on the same controller each time. Functionally harmless but adds unnecessary boilerplate; consider calling once in SetupTest/before the subtests instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@central/graphql/resolvers/image_components_mocked_test.go` around lines 210 -
292, The `setupImageComponentCVEMocks` setup is being repeated in each `t.Run`
subtest, which re-registers the same `AnyTimes()` expectations on the shared
mock container. Move that common mock initialization out of the individual
subtests in `image_components_mocked_test.go`—ideally into `SetupTest` or once
before the subtests—so the `query without filters`, `query with vulnQuery
filter`, `query with fixable filter`, and `query with combined filters` cases
only focus on query-specific inputs.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@central/graphql/resolvers/image_components_mocked_test.go`:
- Around line 210-292: The `setupImageComponentCVEMocks` setup is being repeated
in each `t.Run` subtest, which re-registers the same `AnyTimes()` expectations
on the shared mock container. Move that common mock initialization out of the
individual subtests in `image_components_mocked_test.go`—ideally into
`SetupTest` or once before the subtests—so the `query without filters`, `query
with vulnQuery filter`, `query with fixable filter`, and `query with combined
filters` cases only focus on query-specific inputs.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 43f51f17-5421-4bac-98d2-a0cdff8b8225

📥 Commits

Reviewing files that changed from the base of the PR and between 58ce645 and 3c9dd40.

📒 Files selected for processing (1)

central/graphql/resolvers/image_components_mocked_test.go

codecov · 2026-07-03T12:48:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.33%. Comparing base (3847494) to head (1eb8400).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21542      +/-   ##
==========================================
- Coverage   50.36%   50.33%   -0.03%     
==========================================
  Files        2844     2844              
  Lines      218429   218476      +47     
==========================================
- Hits       110004   109964      -40     
- Misses     100445   100510      +65     
- Partials     7980     8002      +22

Flag	Coverage Δ
go-unit-tests	`50.33% <ø> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-07-03T12:51:56Z

🚀 Build Images Ready

Images are ready for commit c1fd65e. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-410-gc1fd65eb66

vikin91

I am not a graphql expert, but gave it a shot anyway. If you need a deeper review, then I would suggest to involve an additional reviewer.

Solid addition of working test coverage. I have few observations in the comments, but none of them are blocking.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@central/graphql/resolvers/image_components_mocked_test.go`:
- Around line 286-288: The test setup in image_components_mocked_test.go uses
invalid new(...) calls that pass values instead of types, so fix the
initialization around the observed vulnerability fields by replacing the bad
pointers in the test block that defines now, moderateVuln, and observedState.
Use the existing symbols time.Now,
storage.VulnerabilitySeverity_MODERATE_VULNERABILITY_SEVERITY, and
storage.VulnerabilityState_OBSERVED by first assigning them to local values and
then taking their addresses where a pointer is required.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 578fe3d1-bc5a-4ac7-b8c3-85ac73c3a3de

📥 Commits

Reviewing files that changed from the base of the PR and between 475c4c2 and 1eb8400.

📒 Files selected for processing (1)

central/graphql/resolvers/image_components_mocked_test.go

rhybrillou · 2026-07-07T15:21:03Z

/retest

rhybrillou · 2026-07-08T08:10:35Z

/retest

openshift-ci Bot added the do-not-merge/work-in-progress label Jul 3, 2026

github-actions Bot added the area/central label Jul 3, 2026

coderabbitai Bot reviewed Jul 3, 2026

View reviewed changes

rhybrillou mentioned this pull request Jul 3, 2026

tests(graphql): Add interface-implementation method alignment tests #21543

Merged

4 of 5 tasks

This was referenced Jul 3, 2026

refactor: move graphQL resolvers from interface to raw types #21544

Merged

chore(deps): bump github.com/graph-gophers/graphql-go 1.5.0 -> 1.10.2 #20716

Merged

chore: revert to GraphQL interface resolvers #21517

Merged

rhybrillou marked this pull request as ready for review July 3, 2026 14:10

openshift-ci Bot removed the do-not-merge/work-in-progress label Jul 3, 2026

vikin91 approved these changes Jul 6, 2026

View reviewed changes

rhybrillou added 3 commits July 6, 2026 14:43

test(graphql): Add mocked tests for ImageComponent resolver

142ad11

Move tests to a common file

977d078

reduce code duplication in image component graphql test

475c4c2

rhybrillou force-pushed the master-yann/graphql/image_component_tests branch from 3c9dd40 to 475c4c2 Compare July 6, 2026 12:51

Address review comments

1eb8400

coderabbitai Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread central/graphql/resolvers/image_components_mocked_test.go

rhybrillou merged commit c1fd65e into master Jul 8, 2026
117 of 121 checks passed

rhybrillou deleted the master-yann/graphql/image_component_tests branch July 8, 2026 09:29

Conversation

rhybrillou commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

openshift-ci Bot commented Jul 3, 2026

Uh oh!

coderabbitai Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Build Images Ready

Uh oh!

vikin91 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rhybrillou commented Jul 7, 2026

Uh oh!

rhybrillou commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rhybrillou commented Jul 3, 2026 •

edited

Loading

coderabbitai Bot commented Jul 3, 2026 •

edited

Loading

codecov Bot commented Jul 3, 2026 •

edited

Loading

github-actions Bot commented Jul 3, 2026 •

edited

Loading