Skip to content

chore: revert to GraphQL interface resolvers - #21517

Merged
rhybrillou merged 5 commits into
master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0from
master-yann/graphql/restore-interface-resolvers
Jul 13, 2026
Merged

rhybrillou merged 5 commits into
master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0from
master-yann/graphql/restore-interface-resolvers

Conversation

@rhybrillou

@rhybrillou rhybrillou commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

The graphql-go dependency introduced a regression in pieces of the schema to resolver mapping and to the associated query execution.
The conditions for that regression are present in some of our resolvers.
Assuming the dependency fixes the regression, this PR reverts the changes introduced to work around it.

This PR is part of a stack:

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

How I validated my change

CI run.

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions

github-actions Bot commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 5c5fae0. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-453-g5c5fae09f5

@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from 972aa01 to 3e809f9 Compare July 1, 2026 12:56
@rhybrillou
rhybrillou force-pushed the master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 branch from fa74b76 to 3dbf095 Compare July 3, 2026 12:56
@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from 3e809f9 to 847a73f Compare July 3, 2026 13:41
@rhybrillou
rhybrillou force-pushed the master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 branch from 3dbf095 to db8a3d0 Compare July 3, 2026 13:57
@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from 24785d0 to e7c620f Compare July 3, 2026 13:58
@codecov

codecov Bot commented Jul 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.51351% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.33%. Comparing base (349a4ec) to head (5c5fae0).

Files with missing lines Patch % Lines
...ntral/graphql/resolvers/cluster_vulnerabilities.go 55.00% 8 Missing and 1 partial ⚠️
central/graphql/resolvers/images.go 0.00% 9 Missing ⚠️
central/graphql/resolvers/image_cve_core.go 0.00% 6 Missing ⚠️
central/graphql/resolvers/image_vulnerabilities.go 71.42% 4 Missing and 2 partials ⚠️
central/graphql/resolvers/node_vulnerabilities.go 72.72% 4 Missing and 2 partials ⚠️
central/graphql/resolvers/clusters.go 37.50% 5 Missing ⚠️
central/graphql/resolvers/node_components.go 78.94% 3 Missing and 1 partial ⚠️
central/graphql/resolvers/image_components.go 76.92% 2 Missing and 1 partial ⚠️
central/graphql/resolvers/deployments.go 0.00% 2 Missing ⚠️
central/graphql/resolvers/namespaces.go 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                                               Coverage Diff                                               @@
##           master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0   #21517      +/-   ##
===============================================================================================================
- Coverage                                                                        50.33%   50.33%   -0.01%     
===============================================================================================================
  Files                                                                             2845     2845              
  Lines                                                                           218489   218536      +47     
===============================================================================================================
+ Hits                                                                            109982   110005      +23     
- Misses                                                                          100510   100527      +17     
- Partials                                                                          7997     8004       +7     
Flag Coverage Δ
go-unit-tests 50.33% <63.51%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rhybrillou
rhybrillou marked this pull request as ready for review July 3, 2026 15:18
@rhybrillou
rhybrillou requested a review from a team as a code owner July 3, 2026 15:18
@rhybrillou
rhybrillou force-pushed the master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 branch from db8a3d0 to 7fa2a20 Compare July 6, 2026 12:52
@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from e7c620f to 386d381 Compare July 6, 2026 12:52
@rhybrillou
rhybrillou force-pushed the master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 branch from 7fa2a20 to 4175ff3 Compare July 7, 2026 10:02
@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from 386d381 to 044cbb9 Compare July 7, 2026 10:02
@rhybrillou
rhybrillou force-pushed the master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 branch from 4175ff3 to 34075cd Compare July 8, 2026 09:51
@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from 044cbb9 to 2f740df Compare July 8, 2026 09:51
@rhybrillou
rhybrillou force-pushed the master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 branch from 34075cd to 3220bd2 Compare July 8, 2026 16:04
@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from 2f740df to c099521 Compare July 8, 2026 16:04
@rhybrillou
rhybrillou force-pushed the master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 branch from 3220bd2 to 349a4ec Compare July 9, 2026 09:45
@rhybrillou
rhybrillou force-pushed the master-yann/graphql/restore-interface-resolvers branch from c099521 to 5c5fae0 Compare July 9, 2026 09:45
@rhybrillou

Copy link
Copy Markdown
Contributor Author

/retest

@rhybrillou
rhybrillou merged commit a32f988 into master-yann/dependabot/go_modules/github.com/graph-gophers/graphql-go-1.6.0 Jul 13, 2026
104 of 110 checks passed
@rhybrillou
rhybrillou deleted the master-yann/graphql/restore-interface-resolvers branch July 13, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant