Skip to content

chore(bench): measure heap in alert upsert test #17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janisz merged 5 commits into from
Nov 7, 2025
Merged

chore(bench): measure heap in alert upsert test #17564

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d41e148
chore(bench): measure heap in alert upsert test
janisz Oct 30, 2025
847d887
fix
janisz Oct 30, 2025
5d100f1
report start metrics
janisz Nov 4, 2025
9943b9b
Merge branch 'master' into meaurse_max_heap_bytes_in_upsert_test
janisz Nov 4, 2025
d7299b6
fix
janisz Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions central/alert/datastore/internal/store/postgres/bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ package postgres
import (
"context"
"fmt"
"runtime"
"testing"
"time"

"github.com/stackrox/rox/generated/storage"
"github.com/stackrox/rox/pkg/postgres/pgtest"
Expand Down Expand Up @@ -39,12 +41,27 @@ func BenchmarkMany(b *testing.B) {

for n := 1; n < alertsNum; n = n * 2 {
b.Run(fmt.Sprintf("upsert %d alerts", n), func(b *testing.B) {
startHeap, startHeapObj := getHeapAllocAndObjects(0, 0)
var maxHeap uint64
var maxHeapObj uint64
ticker := time.NewTicker(10 * time.Millisecond)
go func() {
for range ticker.C {
maxHeap, maxHeapObj = getHeapAllocAndObjects(maxHeap, maxHeapObj)
}
}()

for b.Loop() {
err := store.UpsertMany(ctx, alerts[:n])
if err != nil {
b.Fatal(err)
}
}
ticker.Stop()
b.ReportMetric(float64(maxHeap-startHeap), "max_heap_bytes")
b.ReportMetric(float64(maxHeapObj-startHeapObj), "max_heap_objects")
Comment thread
janisz marked this conversation as resolved.
b.ReportMetric(float64(startHeap), "start_heap_bytes")
b.ReportMetric(float64(startHeapObj), "start_heap_objects")
})
b.Run(fmt.Sprintf("get %d alerts", n), func(b *testing.B) {
for b.Loop() {
Expand All @@ -71,3 +88,12 @@ func BenchmarkMany(b *testing.B) {
})
}
}

func getHeapAllocAndObjects(maxHeap uint64, maxHeapObj uint64) (uint64, uint64) {
runtime.GC()
var m runtime.MemStats
runtime.ReadMemStats(&m)
maxHeap = max(maxHeap, m.HeapAlloc)
maxHeapObj = max(maxHeapObj, m.HeapObjects)
return maxHeap, maxHeapObj
}
Loading