Skip to content

chore(bench): measure heap in alert upsert test - #17564

Merged
janisz merged 5 commits into
masterfrom
meaurse_max_heap_bytes_in_upsert_test
Nov 7, 2025
Merged

janisz merged 5 commits into
masterfrom
meaurse_max_heap_bytes_in_upsert_test

Conversation

@janisz

@janisz janisz commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Description

This PR measures max heap bytes and objects in alert upsert benchmark.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@rhacs-bot

rhacs-bot commented Oct 30, 2025 •

Copy link
Copy Markdown
Contributor

Images are ready for the commit at d7299b6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-235-gd7299b6e0e.

@codecov

codecov Bot commented Oct 30, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.05%. Comparing base (71a49ae) to head (d7299b6).
⚠️ Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17564      +/-   ##
==========================================
+ Coverage   48.73%   49.05%   +0.31%     
==========================================
  Files        2729     2728       -1     
  Lines      203213   201839    -1374     
==========================================
- Hits        99034    99010      -24     
+ Misses      96430    95087    -1343     
+ Partials     7749     7742       -7     
Flag Coverage Δ
go-unit-tests 49.05% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread central/alert/datastore/internal/store/postgres/bench_test.go Outdated
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
janisz requested a review from vikin91 October 30, 2025 15:06
Comment thread central/alert/datastore/internal/store/postgres/bench_test.go
@janisz
janisz enabled auto-merge (squash) November 4, 2025 11:02
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz
janisz merged commit 97882bf into master Nov 7, 2025
87 of 88 checks passed
@janisz
janisz deleted the meaurse_max_heap_bytes_in_upsert_test branch November 7, 2025 14:22
ajheflin pushed a commit that referenced this pull request Nov 7, 2025
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants