Repository navigation
Move plot code into a separate set of files - #925
Merged
Merged
Conversation
vtronko
requested changes
Jan 9, 2017
| <x>0</x> | ||
| <y>0</y> | ||
| <width>473</width> | ||
| <width>607</width> |
| <widget class="QMenu" name="menuRemote"> | ||
| <property name="title"> | ||
| <string>Remote</string> | ||
| <string>Re&mote</string> |
Member
Author
There was a problem hiding this comment.
Thanks, will look into those tomorrow or so! By the way, does anyone know how to prevent Qt Creator from adding keyboard shortcuts like these automatically?
| <action name="fileExportJsonAction"> | ||
| <property name="text"> | ||
| <string>Table(s) to JSON...</string> | ||
| <string>Table(&s) to JSON...</string> |
| <action name="actionOpen_Remote"> | ||
| <property name="text"> | ||
| <string>Open from Remote</string> | ||
| <string>&Open from Remote</string> |
| <action name="actionSave_Remote"> | ||
| <property name="text"> | ||
| <string>Save to Remote</string> | ||
| <string>&Save to Remote</string> |
Member
|
Not me. If we need to, we could ask on the Qt IRC channel. |
MKleusberg
force-pushed
the
plotrefactoring
branch
from
January 13, 2017 16:58
0e68015 to
fbb3228
Compare
This cleans up the main window class a bit which was getting quite large and a bit harder to maintain than necessary. This commit also includes two minor fixes to the plot system: - The plot widgets are now disabled when no database file is opened. - The progress bar shown when fetching all data is now initialised with the correct row numbers. Other than that this commit should in theory not change any functionality.
MKleusberg
force-pushed
the
plotrefactoring
branch
from
January 13, 2017 17:00
fbb3228 to
a6f2a7d
Compare
Member
Author
|
Just updated the PR as requested 😃 Has anybody done some testing yet to check if it breaks some plotting functionality? |
vtronko
approved these changes
Jan 13, 2017
Member
|
@MKleusberg never touched plots, sorry. @revolter @chrisjlocke are you up for some testing? |
Member
|
Initial thoughts:
The above issues (apart from the widget not being disabled) are nothing much to do with this actual pull request, so can be ignored if required... ;) |
Member
Author
|
Thanks for the tests, @chrisjlocke! :D I'll open a new issue for these problems, so they won't get lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up the main window class a bit which was getting quite large
and a bit harder to maintain than necessary.
This commit also includes two minor fixes to the plot system:
the correct row numbers.
Other than that this commit should in theory not change any
functionality.
I'm opening a PR for this, so hopefully some of you will test this before merging. In theory everything should behave just as before but I wouldn't want to count on it just yet 😃 Please let me know if you find any problems with this.