Repository navigation
Some issues with the plot feature #950
Description
Here are some issues @chrisjlocke found in the plotting feature testing the latest version from master. See PR #925 for details.
Initial thoughts:
* Widget is not disabled when a database is not open
* When 'Browse Data' tab is clicked on, X axis gets unticked (ie, when user flips from execute SQL to Browse Data) Two 'rowid' rows momentarily exist in the grid, but this is just a quirk of the grid re-populating I think.
* When an item in the X axis is ticked, ticking another item unticks the original item, but the item you clicked on is not ticked, so you have to click the item you want again.
* When selecting 'row #' as the X axis, '65536' is displayed as a label, rather than 'row #'.
Activity
plot: Correctly disable signals when needed
plot: Fix labels for 'Row #' columns
MKleusberg commentedon May 8, 2017
All done 😃 The first one is a little tricky because the widget is disabled, it just doesn't look like it. But that's something we can't do much about...
@chrisjlocke Can you double check that the other three are fixed in the next nightly build? 😃
chrisjlocke commentedon May 8, 2017
Will do. 😼
justinclift commentedon May 17, 2017
@chrisjlocke Ping. 😉
MKleusberg commentedon Oct 21, 2017
Ping? 😉
chrisjlocke commentedon Oct 21, 2017
6 months ago?! Whoops. Sorry!
chrisjlocke commentedon Oct 31, 2017
Apologies for the delay. Yes, the issues I raised have been resolved. Many thanks!
The only quirk I have now is that if you untick a Y axis field, the axis label is removed. This doesn't happen if the X axis is unticked.
So here, the label is showing ap_date, but its unticked. Just a minor thing...
justinclift commentedon Dec 7, 2017
This sounds like it might have been fixed a few days ago by 1626345, which cleans up the plot y axis check handling.
@chrisjlocke Do you have time to check it quickly? 😄
chrisjlocke commentedon Dec 7, 2017
🏃 Am on it...
chrisjlocke commentedon Dec 7, 2017
Nope.☹️
Unticking doesn't remove the label.
justinclift commentedon Dec 7, 2017
Doh! Thanks @chrisjlocke. 😄
k, this sounds like a fairly easy fix though, as @MKleusberg was updating this same section of code the other day. 😄
plot: Remove axis labels when there is no plot
MKleusberg commentedon Dec 7, 2017
Should be fixed in the next nightly build 😄
chrisjlocke commentedon Dec 7, 2017
You should make that your signature. 😆
justinclift commentedon Dec 7, 2017
I've just manually started the Windows nightly build script again, so in ~1/2 hour we can test this instead of waiting until tomorrow. 😉
chrisjlocke commentedon Dec 7, 2017
justinclift commentedon Dec 7, 2017
k, they're built and uploaded. 😄
https://nightlies.sqlitebrowser.org/latest/
chrisjlocke commentedon Dec 7, 2017
Ticking Y axis column labels doesn't show anything if the X axis is unticked, but I assume thats not a bug per-se as the operation hasn't completed yet... so I'll shut up otherwise this'll never get closed! ;)
Thanks @MKleusberg for the prompt fix!
justinclift commentedon Dec 7, 2017
Awesome. 😄
MKleusberg commentedon Dec 8, 2017
Cool 😄 Thanks again for reporting all these issues, @chrisjlocke 👍