Merged
Conversation
Return non-zero rc instead of None
… be passed in similar to post reqeusts
…lso fixed unicode xml decoding error
…e to pass in as a kwarg
Master -> Develop for 1.6.5
Additional headers on every request and fix unicode decoding issue
auto-doc all class constructor parameters
…s_block Add return code for invalid args block
Python's cstringio doesn't support unicode characters, when encountering them Exceptions are raised. We've decided to use stringio instead, trading potential performance improvements for full unicode support. In Python 2, this may lead to a slight performance hit since we're no longer explicitly using the native version. However, in Python 3 stringio will automatically use the native version if available and there should be no noticeable performance changes.
Searchcommands: add full support for unicode
... by using the six library
Make the explorer example compatible w/ Python 3
Use self._connection
Run CI against Splunk 7.2
- Correct logic to always look for cert files when verify=True - Pass key_file and cert_file to handler from HttpLib - Changed default value of verify to False for backward compat
loganknecht
approved these changes
Dec 5, 2018
| * Add full support for unicode in SearchCommands | ||
| * Add return code for invalid_args block | ||
| * Fixed unicode xml decoding error | ||
| * Added headers argument to get requests so that additional headers can be passed in |
Contributor
There was a problem hiding this comment.
are all of these categorized as bug fixes?
shakeelmohamed
suggested changes
Dec 5, 2018
Contributor
shakeelmohamed
left a comment
There was a problem hiding this comment.
I think we need to update a user-agent somewhere, double check the release steps
shakeelmohamed
approved these changes
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
Minor Changes