Conversation
Contributor
dan1
commented
Dec 3, 2018
- Correct logic to always look for cert files when verify=True
- Pass key_file and cert_file to handler from HttpLib
- Changed default value of verify to False for backward compat
- Correct logic to always look for cert files when verify=True - Pass key_file and cert_file to handler from HttpLib - Changed default value of verify to False for backward compat
shakeelmohamed
approved these changes
Dec 4, 2018
zenmoto
approved these changes
Dec 4, 2018
dan1
added a commit
that referenced
this pull request
Dec 5, 2018
* Add return code for invalid args block Return non-zero rc instead of None * Added headers argument to get requests so that additional headers can be passed in similar to post reqeusts * Added the option of always adding a particular header to a request. Also fixed unicode xml decoding error * Adding additional comments to denote that a headers object is possible to pass in as a kwarg * auto-doc all class constructor parameters * Searchcommands: add full support for unicode Python's cstringio doesn't support unicode characters, when encountering them Exceptions are raised. We've decided to use stringio instead, trading potential performance improvements for full unicode support. In Python 2, this may lead to a slight performance hit since we're no longer explicitly using the native version. However, in Python 3 stringio will automatically use the native version if available and there should be no noticeable performance changes. * update assertion * Make the explorer example compatible w/ Python 3 ... by using the six library * Update binding.py * Run CI against Splunk 7.2 * tests: relax restart timeout * Fix ssl verify to require certs when true (#233) - Correct logic to always look for cert files when verify=True - Pass key_file and cert_file to handler from HttpLib - Changed default value of verify to False for backward compat * Preparing Release 1.6.6 * Cleaned up CHANGELOG.md * Update version to 1.6.6 in User-Agent header * Rev version of examples/searchcommands_app/setup.py to 1.6.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.