Add better handling for Keep-Alive connections#130
Merged
Conversation
Python's httplib generally has bad support for Keep-Alive connections, which is why we never used it. We didn't explicitly ask for "Connection: Close", but it was implicit. Additionally, splunkd would always return it. However, an issue arises when talking to a Load Balancer which issues a Keep-Alive request to splunkd, and returns that header to us. Python then goes into a particular path which the code didn't handle gracefully. What this change does is two-fold: 1. Always request to close the connection via the "Connection: Close" header. 2. If we get back a "Connection: Keep-Alive" header, we properly handle it by not immediately closing our reference to the connection and only doing so when the response has been completed.
|
LGTM |
|
This fixes the problem I was having. Thanks. |
itay
added a commit
that referenced
this pull request
Dec 23, 2015
Add better handling for Keep-Alive connections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python's httplib generally has bad support for Keep-Alive connections,
which is why we never used it. We didn't explicitly ask for "Connection: Close",
but it was implicit. Additionally, splunkd would always return it.
However, an issue arises when talking to a Load Balancer which issues
a Keep-Alive request to splunkd, and returns that header to us. Python
then goes into a particular path which the code didn't handle gracefully.
What this change does is two-fold:
it by not immediately closing our reference to the connection and only
doing so when the response has been completed.