Skip to content

Read response before closing connection.#124

Closed
SlaterByte wants to merge 1 commit intosplunk:masterfrom
SlaterByte:patch-1
Closed

Read response before closing connection.#124
SlaterByte wants to merge 1 commit intosplunk:masterfrom
SlaterByte:patch-1

Conversation

@SlaterByte
Copy link
Copy Markdown

Otherwise response.read() is an empty string.

 Otherwise response.read() is an empty string.
@itay
Copy link
Copy Markdown
Contributor

itay commented Nov 21, 2015

@SlaterByte sorry for the delayed response. Could you:

  1. Sign the contribution agreement?
  2. Rebase this on top of develop (and change the target to be develop), so that you pick up the Travis CI tests?
  3. What version of OS/Python/Splunk were you getting this issue with? I cannot reproduce it, so want to doublecheck.

@itay
Copy link
Copy Markdown
Contributor

itay commented Dec 10, 2015

@SlaterByte there should be a fix for this in #130 - can you look if it works for you?

@ukison
Copy link
Copy Markdown

ukison commented Dec 15, 2015

@itay I am using Mac OS X 10.10.5/Python 2.7.10/Splunk 1.3.1 (1.5.0 is the same), I can't connect to splunk server, because response.read() is an empty string, and this is because the connection is closed before the response.read().
screen shot 2015-12-15 at 12 44 32 pm

@itay
Copy link
Copy Markdown
Contributor

itay commented Dec 15, 2015

@ukison does the fix in the linked PR work for you?

@ukison
Copy link
Copy Markdown

ukison commented Dec 15, 2015

@itay yes, it can fix, thanks.

@itay
Copy link
Copy Markdown
Contributor

itay commented Dec 23, 2015

Closing this PR as it's been superseded with the other one.

@itay itay closed this Dec 23, 2015
mateusz834 pushed a commit that referenced this pull request Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants