Fix for issue #383 & Support for immediate cancellation of servers#384
Conversation
|
Thanks for the pull request. I'm looking into why the CI failed. It's not related to what you've done. I expect to post a pull request to clear that up shortly. |
|
I was wrong. 2 out of the 3 failures were due to other issues (being addressed in #385) but one of the tests is failing 'correctly': https://travis-ci.org/softlayer/softlayer-python/jobs/34384950#L761 |
|
Should be good now. |
There was a problem hiding this comment.
Make sure this fits with our "style guide" for CLI options: http://softlayer-python.readthedocs.org/en/latest/dev/cli.html#defining-a-module
There was a problem hiding this comment.
I virtually just copied this from here: https://github.com/softlayer/softlayer-python/blob/6f5c229c28ce8466c961aec1bcb253e88875bc21/SoftLayer/CLI/modules/iscsi.py
Anything in particular that's not right about it?
There was a problem hiding this comment.
It's correct in isolation, but the description doesn't line up with the other descriptions below it. Here's how it should look:
--immediate Cancels the server immediately (instead of on the billing
anniversary)
--comment=COMMENT An optional comment to add to the cancellation ticket
--reason=REASON An optional cancellation reason. See cancel-reasons for a
list of available optionsIf that doesn't make sense it's not a big deal. I can fix it up later if you want.
There was a problem hiding this comment.
Done. It's pretty now. ;)
|
To avoid pull requests from being tied additional changes that you're working on, it's typical to create a new branch on your fork and use that to submit the pull request. This might help make this a bit clearer: https://guides.github.com/introduction/flow/index.html |
|
+1 |
Fix for issue #383 & Support for immediate cancellation of servers
No description provided.