-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat(scheduled-tasks): pause/resume, mutation toasts, submit guards, empty state #5044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f73281b
feat(scheduled-tasks): pause/resume, mutation toasts, submit guards, …
waleedlatif1 ac2b846
fix(scheduled-tasks): return edit-modal save promise so the modal awa…
waleedlatif1 b46dcbd
refactor(scheduled-tasks): explicit return in edit-modal onSubmit for…
waleedlatif1 9fc5186
fix(scheduled-tasks): optimistic create insert + always-reset submit …
waleedlatif1 3d42b04
revert(scheduled-tasks): drop first-run empty state
waleedlatif1 3aa2b61
fix(scheduled-tasks): lock modal dismiss while a save is in flight
waleedlatif1 79d40f7
fix(settings): align general appearance dropdowns to a uniform width
waleedlatif1 3133458
docs(scheduled-tasks): document why the dismiss guard doesn't block t…
waleedlatif1 c5d659d
fix(scheduled-tasks): disable Delete while an edit save is in flight
waleedlatif1 a14cdbf
refactor(scheduled-tasks): TSDoc over inline comments in task modal
waleedlatif1 a7624ee
fix(scheduled-tasks): gate submit on a synchronous ref to fully block…
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.