The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jun 14, 2026 5:49pm

PR Summary

Medium Risk
Touches schedule persistence and expansion logic for paused recurring jobs; modal submit flow changes could affect edge cases around concurrent delete vs save, though guards were added.

Overview
Adds pause and resume for upcoming recurring tasks via the task context menu (existing disable/reactivate APIs), wired through useScheduledTasks and a new useResumeSchedule hook. Paused series still expand on the calendar with a disabled flag so pills render dimmed and stay discoverable; one-time paused jobs with no history stay hidden.

The create/edit modal now awaits async saves: it stays open on failure, blocks dismiss and double-submit while in flight, and shows in-progress labels on the primary action. Create/update mutations use mutateAsync so rejections propagate to the modal.

Schedule mutations surface success and error toasts (create, update, delete, exclude occurrence, pause, resume). General settings aligns Theme, Timezone, and Snap-to-grid dropdown triggers to a shared 240px width.

^{Reviewed by Cursor Bugbot for commit a7624ee. Configure here.}

@greptile review

@cursor review

Greptile Summary

This PR adds a control and observability layer to the scheduled-tasks module: mutation toasts on every job operation (create/update/delete/pause/resume/exclude), a submit guard that keeps the modal open on failure, pause/resume of recurring tasks via the context menu, and dimmed rendering for paused calendar occurrences.

• Submit guard (task-modal.tsx): handleSubmit is now async, awaiting onSubmit, and uses a submittingRef to prevent double-submission. A stale-closure trick makes programmatic success-close pass through handleOpenChange while user dismisses during flight are blocked.
• Pause / Resume (use-scheduled-tasks.ts, task-context-menu.tsx, schedule-events.ts): pauseTask/resumeTask reuse the existing disable/reactivate endpoints; paused recurring schedules still expand occurrences flagged disabled: true so they remain visible and resumable.
• Toast layer (schedules.ts): onSuccess/onError toast callbacks added to all six mutation hooks; mutateAsync callers wrap the rejection with .catch(() => false), so the onError toast fires once.

Confidence Score: 5/5

The PR is safe to merge — all mutation paths now surface errors via toast and the modal correctly guards against premature close and double-submit.

The submit guard uses a well-reasoned stale-closure pattern that correctly allows programmatic success-close to pass through while blocking all user-initiated dismissals during flight. The mutateAsync to onError to catch chain produces exactly one toast on failure and leaves the modal open with the draft intact. The pause/resume feature is correctly gated to recurring pending tasks only, and paused occurrences continue to expand in the calendar with a disabled flag. The schedule-events logic change is covered by three new unit tests.

No files require special attention.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant U as User
    participant TM as TaskModal
    participant HS as handleSubmit
    participant HK as useScheduledTasks
    participant SQ as schedules.ts
    participant API as API

    U->>TM: Click Schedule or Save
    TM->>HS: handleSubmit()
    HS->>HK: createTask or updateTask
    HK->>SQ: mutateAsync
    SQ->>API: HTTP request
    alt Success
        API-->>SQ: 200 OK
        SQ->>SQ: onSuccess toast.success
        SQ-->>HS: resolves
        HS->>TM: close via stale closure
        TM-->>U: Modal closes
    else Failure
        API-->>SQ: Error
        SQ->>SQ: onError toast.error
        SQ-->>HS: catch returns false
        HS-->>TM: stays open
        TM-->>U: Modal open with toast
    end

_{Reviews (10): Last reviewed commit: "fix(scheduled-tasks): gate submit on a s..." | Re-trigger Greptile}

@greptile review

@cursor review

Greptile Summary

This PR adds a control layer to the scheduled-tasks module: toast feedback on every job mutation, an async submit guard in the create/edit modal (stays open until the task persists, closes only on success), Pause/Resume for recurring tasks via the existing disable/reactivate endpoints, and a first-run empty state in place of the blank calendar grid.

• Submit guard: handleSubmit is now async, uses mutateAsync for create and update, and gates the submit button with a submitting flag — but setSubmitting(false) is only called in the catch branch; the success path relies solely on unmounting via close().
• Pause/Resume: paused recurring schedules are still expanded as disabled: true occurrences (rendered dimmed) so they stay visible and resumable; the context menu toggles Pause↔Resume based on task.disabled, gated to recurring === true.
• Toasts: onSuccess/onError toast callbacks are added uniformly across all six mutation hooks; useResumeSchedule is a new hook that wraps the existing reactivate endpoint with workspace-scoped cache invalidation.

Confidence Score: 4/5

The change is well-scoped and the core Pause/Resume and toast wiring is correct; the only rough edge is the missing setSubmitting(false) on the success path in the modal.

The submit guard is the riskiest new surface: setSubmitting(false) is never called before close() on the success path. In the current wiring this is harmless because the Radix portal unmounts the content on close, discarding the state. If onOpenChange ever fails to actually close the dialog (e.g., a future consumer prevents it), the submit button is permanently stuck in the "Scheduling…" disabled state with no recovery path. The Pause/Resume expansion logic and the disabled flag propagation through schedule-events.ts are correct and well-tested. Toast wiring is consistent across all six mutation hooks.

task-modal.tsx — the handleSubmit async flow; use-scheduled-tasks.ts — the updateTask path no longer synchronously clears selectedTask (now delegated to the modal's close() callback).

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant U as User
    participant TM as TaskModal
    participant UST as useScheduledTasks
    participant SQ as schedules.ts (React Query)
    participant API as API

    U->>TM: clicks Schedule / Save
    TM->>TM: setSubmitting(true)
    TM->>UST: onSubmit(draft) → createTask / updateTask
    UST->>SQ: mutateAsync(body)
    SQ->>API: POST /schedules or PATCH /schedules/:id
    API-->>SQ: 200 OK
    SQ->>SQ: onSuccess → toast.success(...)
    SQ-->>UST: Promise resolves
    UST-->>TM: Promise resolves
    TM->>TM: close() → onOpenChange(false)
    Note right of TM: setSubmitting(false) never called on success path

    alt API error
        API-->>SQ: 4xx / 5xx
        SQ->>SQ: onError → toast.error(...)
        SQ-->>UST: Promise rejects
        UST-->>TM: throws
        TM->>TM: catch → setSubmitting(false)
        Note right of TM: Modal stays open with draft intact
    end

    U->>TM: right-clicks task chip
    TM->>UST: pauseTask(scheduleId) / resumeTask(scheduleId)
    UST->>SQ: disableSchedule.mutate / resumeSchedule.mutate
    UST->>UST: setSelectedTask(null) immediately
    SQ->>API: PATCH /schedules/:id (disable/reactivate)
    API-->>SQ: 200 OK
    SQ->>SQ: onSuccess → toast.success(...)
    SQ->>SQ: onSettled → invalidateQueries(list + details)

_{Reviews (2): Last reviewed commit: "refactor(scheduled-tasks): explicit retu..." | Re-trigger Greptile}

@greptile review

@cursor review

@greptile review

@cursor review

@greptile review

@cursor review

@greptile review

@cursor review

@greptile review

@cursor review

@greptile review

@cursor review

@greptile review

@cursor review