Skip to content

feat(files): expand file editor to support more formats, add docx/xlsx preview #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 11 commits into from
Apr 5, 2026
Merged

feat(files): expand file editor to support more formats, add docx/xlsx preview #3971

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6fc7ab4
feat(files): expand file editor to support more formats, add docx/xls…
waleedlatif1 Apr 5, 2026
646f8d1
lint
waleedlatif1 Apr 5, 2026
edc103d
fix(files): narrow fileData type for closure in docx/xlsx preview eff…
waleedlatif1 Apr 5, 2026
13c4919
fix(files): address PR review — fix xlsx type, simplify error helper,…
waleedlatif1 Apr 5, 2026
0cd5e46
add mothership read externsions
icecrasher321 Apr 5, 2026
71b20bf
fix(files): update upload test — js is now a supported extension
waleedlatif1 Apr 5, 2026
846214f
fix(files): deduplicate code extensions, handle dotless filenames
waleedlatif1 Apr 5, 2026
a284499
fix(files): lower xlsx preview row cap to 1k and type workbookRef pro…
waleedlatif1 Apr 5, 2026
a7b732b
refactor(files): extract shared DataTable, isolate client-safe constants
waleedlatif1 Apr 5, 2026
e31cf4d
refactor(validation): remove Node path import, use plain string extra…
waleedlatif1 Apr 5, 2026
6c4b02e
lint
waleedlatif1 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(files): lower xlsx preview row cap to 1k and type workbookRef pro… 
…perly

Reduces XLSX_MAX_ROWS from 10,000 to 1,000 to prevent browser sluggishness
on large spreadsheets. Types workbookRef with the proper xlsx.WorkBook
interface instead of unknown, removing the unsafe cast.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Apr 5, 2026
commit a284499de3095712a7de1b691639961d3e775e62
6 changes: 3 additions & 3 deletions apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ h1, h2, h3, h4, h5, h6 { margin: 16px 0 8px; }
</style></head><body>${html}</body></html>`
}

const XLSX_MAX_ROWS = 10_000
const XLSX_MAX_ROWS = 1_000
Comment thread
waleedlatif1 marked this conversation as resolved.

interface XlsxSheet {
name: string
Expand All @@ -961,7 +961,7 @@ const XlsxPreview = memo(function XlsxPreview({
const [activeSheet, setActiveSheet] = useState(0)
const [currentSheet, setCurrentSheet] = useState<XlsxSheet | null>(null)
const [renderError, setRenderError] = useState<string | null>(null)
const workbookRef = useRef<unknown>(null)
const workbookRef = useRef<import('xlsx').WorkBook | null>(null)

useEffect(() => {
if (!fileData) return
Expand Down Expand Up @@ -1002,7 +1002,7 @@ const XlsxPreview = memo(function XlsxPreview({
async function parseSheet() {
try {
const XLSX = await import('xlsx')
const workbook = workbookRef.current as ReturnType<typeof XLSX.read>
const workbook = workbookRef.current!
const name = sheetNames[activeSheet]
const sheet = workbook.Sheets[name]
const allRows = XLSX.utils.sheet_to_json<string[]>(sheet, { header: 1 })
Expand Down
Loading