Skip to content

feat(files): expand file editor to support more formats, add docx/xlsx preview #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 11 commits into from
Apr 5, 2026
Merged

feat(files): expand file editor to support more formats, add docx/xlsx preview #3971

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6fc7ab4
feat(files): expand file editor to support more formats, add docx/xls…
waleedlatif1 Apr 5, 2026
646f8d1
lint
waleedlatif1 Apr 5, 2026
edc103d
fix(files): narrow fileData type for closure in docx/xlsx preview eff…
waleedlatif1 Apr 5, 2026
13c4919
fix(files): address PR review — fix xlsx type, simplify error helper,…
waleedlatif1 Apr 5, 2026
0cd5e46
add mothership read externsions
icecrasher321 Apr 5, 2026
71b20bf
fix(files): update upload test — js is now a supported extension
waleedlatif1 Apr 5, 2026
846214f
fix(files): deduplicate code extensions, handle dotless filenames
waleedlatif1 Apr 5, 2026
a284499
fix(files): lower xlsx preview row cap to 1k and type workbookRef pro…
waleedlatif1 Apr 5, 2026
a7b732b
refactor(files): extract shared DataTable, isolate client-safe constants
waleedlatif1 Apr 5, 2026
e31cf4d
refactor(validation): remove Node path import, use plain string extra…
waleedlatif1 Apr 5, 2026
6c4b02e
lint
waleedlatif1 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(files): address PR review — fix xlsx type, simplify error helper,… 
… tighten iframe sandbox
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Apr 5, 2026
commit 13c491947ea33880294a2a0c46eec1eb382d78a2
6 changes: 3 additions & 3 deletions apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/file-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ const ImagePreview = memo(function ImagePreview({ file }: { file: WorkspaceFileR
})

function resolvePreviewError(fetchError: Error | null, renderError: string | null): string | null {
if (fetchError) return fetchError instanceof Error ? fetchError.message : 'Failed to load file'
if (fetchError) return fetchError.message
return renderError
}

Expand Down Expand Up @@ -955,7 +955,7 @@ const DocxPreview = memo(function DocxPreview({
<div className='flex flex-1 overflow-hidden'>
<iframe
srcDoc={buildDocxPreviewHtml(html)}
sandbox='allow-same-origin'
sandbox=''
title={file.name}
className='h-full w-full border-0'
/>
Expand Down Expand Up @@ -1013,7 +1013,7 @@ const XlsxPreview = memo(function XlsxPreview({
try {
setRenderError(null)
const XLSX = await import('xlsx')
const workbook = XLSX.read(data, { type: 'array' })
const workbook = XLSX.read(new Uint8Array(data), { type: 'array' })
if (!cancelled) {
Comment thread
waleedlatif1 marked this conversation as resolved.
workbookRef.current = workbook
setSheetNames(workbook.SheetNames)
Expand Down
Loading