Skip to content

fix(subflows): subflow-child selection issues, subflow error logs #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 8 commits into from
Mar 19, 2026
Merged

fix(subflows): subflow-child selection issues, subflow error logs #3656

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ebd570a
fix(subflows): subflow-child selection issues, subflow error logs
icecrasher321 Mar 18, 2026
b110966
address comments
icecrasher321 Mar 18, 2026
972d0a5
make selection context more reliable
icecrasher321 Mar 18, 2026
67657b9
fix more multiselect issues
icecrasher321 Mar 18, 2026
e6b4f78
fix shift selection ordering to work correctly
icecrasher321 Mar 19, 2026
cd4adf6
fix more comments
icecrasher321 Mar 19, 2026
6985386
address more comments
icecrasher321 Mar 19, 2026
9f22e6a
reuse helper
icecrasher321 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
reuse helper
  • Loading branch information
@icecrasher321
icecrasher321 committed Mar 19, 2026
commit 9f22e6a3415774acbee5be04f470c47bebd5d2cc
6 changes: 5 additions & 1 deletion apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ import {
getClampedPositionForNode,
getDescendantBlockIds,
getEdgeSelectionContextId,
getNodeSelectionContextId,
getWorkflowLockToggleIds,
isBlockProtected,
isEdgeProtected,
Expand Down Expand Up @@ -3205,7 +3206,10 @@ const WorkflowContent = React.memo(
const draggedParentId = blocks[node.id]?.data?.parentId
const parentIsSelected =
draggedParentId && selectedNodes.some((n) => n.id === draggedParentId)
if (!parentIsSelected) {
const contextMismatch =
getNodeSelectionContextId(draggedNodeInSelected, blocks) !==
getNodeSelectionContextId(selectedNodes[0], blocks)
if (!parentIsSelected && !contextMismatch) {
setDisplayNodes((currentNodes) =>
currentNodes.map((n) => (n.id === node.id ? { ...n, selected: true } : n))
)
Expand Down
Loading