Skip to content

fix(subflows): subflow-child selection issues, subflow error logs #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 8 commits into from
Mar 19, 2026
Merged

fix(subflows): subflow-child selection issues, subflow error logs #3656

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ebd570a
fix(subflows): subflow-child selection issues, subflow error logs
icecrasher321 Mar 18, 2026
b110966
address comments
icecrasher321 Mar 18, 2026
972d0a5
make selection context more reliable
icecrasher321 Mar 18, 2026
67657b9
fix more multiselect issues
icecrasher321 Mar 18, 2026
e6b4f78
fix shift selection ordering to work correctly
icecrasher321 Mar 19, 2026
cd4adf6
fix more comments
icecrasher321 Mar 19, 2026
6985386
address more comments
icecrasher321 Mar 19, 2026
9f22e6a
reuse helper
icecrasher321 Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address more comments
  • Loading branch information
@icecrasher321
icecrasher321 committed Mar 19, 2026
commit 698538644764ac82f65d4448f70db5b8d313583f
26 changes: 16 additions & 10 deletions apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,16 +169,17 @@ function mapEdgesByNode(edges: Edge[], nodeIds: Set<string>): Map<string, Edge[]

/**
* Syncs the panel editor with the current selection state.
* Shows block details when exactly one block is selected, clears otherwise.
* Shows the last selected block in the panel. Clears when nothing is selected.
*/
function syncPanelWithSelection(selectedIds: string[]) {
const { currentBlockId, clearCurrentBlock, setCurrentBlockId } = usePanelEditorStore.getState()
if (selectedIds.length === 1 && selectedIds[0] !== currentBlockId) {
setCurrentBlockId(selectedIds[0])
} else if (selectedIds.length === 0 && currentBlockId) {
clearCurrentBlock()
} else if (selectedIds.length > 1 && currentBlockId) {
clearCurrentBlock()
if (selectedIds.length === 0) {
if (currentBlockId) clearCurrentBlock()
} else {
const lastSelectedId = selectedIds[selectedIds.length - 1]
if (lastSelectedId !== currentBlockId) {
setCurrentBlockId(lastSelectedId)
}
}
}

Expand Down Expand Up @@ -2477,10 +2478,15 @@ const WorkflowContent = React.memo(
// Local state for nodes - allows smooth drag without store updates on every frame
const [displayNodes, setDisplayNodes] = useState<Node[]>([])

const selectedNodeIds = useMemo(
() => displayNodes.filter((node) => node.selected).map((node) => node.id),
[displayNodes]
)
const selectedNodeIdsKey = selectedNodeIds.join(',')

useEffect(() => {
const selectedIds = displayNodes.filter((node) => node.selected).map((node) => node.id)
syncPanelWithSelection(selectedIds)
}, [displayNodes])
syncPanelWithSelection(selectedNodeIds)
}, [selectedNodeIdsKey])

useEffect(() => {
// Check for pending selection (from paste/duplicate), otherwise preserve existing selection
Expand Down
Loading