Skip to content

fix(knowledge): infer MIME type from file extension in create/upsert tools #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Mar 18, 2026
Merged

fix(knowledge): infer MIME type from file extension in create/upsert tools #3651

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
daeaea6
fix(knowledge): infer MIME type from file extension in create/upsert …
waleedlatif1 Mar 18, 2026
6c6ba81
refactor(knowledge): reuse existing getMimeTypeFromExtension from upl…
waleedlatif1 Mar 18, 2026
0e16936
fix(knowledge): fix btoa stack overflow and duplicate encoding in cre…
waleedlatif1 Mar 18, 2026
fa9f344
fix(knowledge): allowlist text-compatible MIME types in inferDocument…
waleedlatif1 Mar 18, 2026
3be8294
fix(knowledge): remove pdf/rtf from allowlist, normalize unrecognized…
waleedlatif1 Mar 18, 2026
e20ff52
fix(knowledge): handle dotfile names to avoid empty base in filename
waleedlatif1 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(knowledge): reuse existing getMimeTypeFromExtension from upl… 
…oads

Replace duplicate EXTENSION_MIME_MAP and getMimeTypeFromExtension with
the existing, more comprehensive version from lib/uploads/utils/file-utils.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Mar 18, 2026
commit 6c6ba817ef02f106078fec16b36663876193fa4d
34 changes: 12 additions & 22 deletions apps/sim/tools/knowledge/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,24 @@
const EXTENSION_MIME_MAP: Record<string, string> = {
html: 'text/html',
htm: 'text/html',
md: 'text/markdown',
csv: 'text/csv',
json: 'application/json',
yaml: 'application/x-yaml',
yml: 'application/x-yaml',
xml: 'application/xml',
txt: 'text/plain',
} as const

/**
* Infers MIME type from a file extension. Returns `text/plain` for unknown extensions.
*/
export function getMimeTypeFromExtension(ext: string): string {
return EXTENSION_MIME_MAP[ext.toLowerCase()] ?? 'text/plain'
}
import {
getFileExtension,
getMimeTypeFromExtension as getUploadMimeType,
} from '@/lib/uploads/utils/file-utils'

/**
* Extracts extension from a filename and returns the normalized filename and MIME type.
* If no extension is present, appends `.txt` and uses `text/plain`.
* Falls back to `text/plain` for unknown extensions (knowledge docs are always text content).
*/
export function inferDocumentFileInfo(documentName: string): {
Comment thread
waleedlatif1 marked this conversation as resolved.
filename: string
mimeType: string
} {
const dotIndex = documentName.lastIndexOf('.')
if (dotIndex > 0) {
const ext = documentName.slice(dotIndex + 1).toLowerCase()
return { filename: documentName, mimeType: getMimeTypeFromExtension(ext) }
const ext = getFileExtension(documentName)
if (ext) {
const mimeType = getUploadMimeType(ext)
return {
filename: documentName,
mimeType: mimeType === 'application/octet-stream' ? 'text/plain' : mimeType,
}
Comment thread
waleedlatif1 marked this conversation as resolved.
}
return { filename: `${documentName}.txt`, mimeType: 'text/plain' }
}
Expand Down
Loading