Skip to content

fix(knowledge): infer MIME type from file extension in create/upsert tools #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 6 commits into from
Mar 18, 2026
Merged

fix(knowledge): infer MIME type from file extension in create/upsert tools #3651

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
daeaea6
fix(knowledge): infer MIME type from file extension in create/upsert …
waleedlatif1 Mar 18, 2026
6c6ba81
refactor(knowledge): reuse existing getMimeTypeFromExtension from upl…
waleedlatif1 Mar 18, 2026
0e16936
fix(knowledge): fix btoa stack overflow and duplicate encoding in cre…
waleedlatif1 Mar 18, 2026
fa9f344
fix(knowledge): allowlist text-compatible MIME types in inferDocument…
waleedlatif1 Mar 18, 2026
3be8294
fix(knowledge): remove pdf/rtf from allowlist, normalize unrecognized…
waleedlatif1 Mar 18, 2026
e20ff52
fix(knowledge): handle dotfile names to avoid empty base in filename
waleedlatif1 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(knowledge): fix btoa stack overflow and duplicate encoding in cre… 
…ate_document

Same fixes as upsert_document: use loop-based String.fromCharCode
instead of spread, consolidate duplicate TextEncoder calls, and
check byte length instead of character length for 1MB limit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Mar 18, 2026
commit 0e169360378c945c714c49706623daf03249af1b
22 changes: 14 additions & 8 deletions apps/sim/tools/knowledge/create_document.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,17 +66,23 @@ export const knowledgeCreateDocumentTool: ToolConfig<any, KnowledgeCreateDocumen
if (!textContent || textContent.length < 1) {
throw new Error('Document content cannot be empty')
}
if (textContent.length > 1000000) {
const utf8Bytes = new TextEncoder().encode(textContent)
const contentBytes = utf8Bytes.length

if (contentBytes > 1_000_000) {
throw new Error('Document content exceeds maximum size of 1MB')
}

const contentBytes = new TextEncoder().encode(textContent).length

const utf8Bytes = new TextEncoder().encode(textContent)
const base64Content =
typeof Buffer !== 'undefined'
? Buffer.from(textContent, 'utf8').toString('base64')
: btoa(String.fromCharCode(...utf8Bytes))
let base64Content: string
if (typeof Buffer !== 'undefined') {
base64Content = Buffer.from(textContent, 'utf8').toString('base64')
} else {
let binary = ''
for (let i = 0; i < utf8Bytes.length; i++) {
binary += String.fromCharCode(utf8Bytes[i])
}
base64Content = btoa(binary)
}

const { filename, mimeType } = inferDocumentFileInfo(documentName)
const dataUri = `data:${mimeType};base64,${base64Content}`
Expand Down
Loading