Skip to content

improvement(tables): tables multi-select, keyboard shortcuts, and docs #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 11 commits into from
Mar 17, 2026
Merged

improvement(tables): tables multi-select, keyboard shortcuts, and docs #3615

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
11fce3b
added docs for tables
waleedlatif1 Mar 16, 2026
3e4241c
fix: remove generated files and move image to correct path
waleedlatif1 Mar 16, 2026
f326b05
fix(tables): skip gap positions in handleCopy for checked rows
waleedlatif1 Mar 16, 2026
e25770b
fix(tables): remove dead props from DataRow and PositionGapRows
waleedlatif1 Mar 17, 2026
116648b
fix(tables): clear range selection on Shift+Space to prevent mixed state
waleedlatif1 Mar 17, 2026
4ea4490
fix(tables): remove dead handleRowMouseDown and handleRowMouseEnter
waleedlatif1 Mar 17, 2026
29c765c
fix(tables): move Escape and Cmd+A above anchor guard
waleedlatif1 Mar 17, 2026
3e51e1c
fix(tables): Shift+Space preserves anchor for continued keyboard use
waleedlatif1 Mar 17, 2026
ad34616
fix(tables): only add real row positions in shift-click range select
waleedlatif1 Mar 17, 2026
57d7f76
fix(tables): Delete/Backspace works after Cmd+A select all
waleedlatif1 Mar 17, 2026
4c16333
docs(tables): clarify Delete/Backspace clears all columns in checkbox…
waleedlatif1 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tables): remove dead props from DataRow and PositionGapRows 
onRowMouseDown, onRowMouseEnter, and onClearSelection were no longer
used after the checkbox td was unified to use onRowToggle exclusively.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Mar 17, 2026
commit e25770b26509fe3a69bf0aa2d7532db649387fed
22 changes: 1 addition & 21 deletions apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,8 +1582,6 @@ export function Table({
firstRowUnderHeader={prevPosition === -1}
onCellMouseDown={handleCellMouseDown}
onCellMouseEnter={handleCellMouseEnter}
onRowMouseDown={handleRowMouseDown}
onRowMouseEnter={handleRowMouseEnter}
onRowToggle={handleRowToggle}
/>
)}
Expand All @@ -1609,11 +1607,8 @@ export function Table({
onContextMenu={handleRowContextMenu}
onCellMouseDown={handleCellMouseDown}
onCellMouseEnter={handleCellMouseEnter}
onRowMouseDown={handleRowMouseDown}
onRowMouseEnter={handleRowMouseEnter}
isRowChecked={checkedRows.has(row.position)}
onRowToggle={handleRowToggle}
onClearSelection={handleClearSelection}
/>
</React.Fragment>
)
Expand Down Expand Up @@ -1749,8 +1744,6 @@ interface PositionGapRowsProps {
firstRowUnderHeader?: boolean
onCellMouseDown: (rowIndex: number, colIndex: number, shiftKey: boolean) => void
onCellMouseEnter: (rowIndex: number, colIndex: number) => void
onRowMouseDown: (rowIndex: number, shiftKey: boolean) => void
onRowMouseEnter: (rowIndex: number) => void
onRowToggle: (rowIndex: number, shiftKey: boolean) => void
}

Expand All @@ -1764,8 +1757,6 @@ const PositionGapRows = React.memo(
firstRowUnderHeader = false,
onCellMouseDown,
onCellMouseEnter,
onRowMouseDown,
onRowMouseEnter,
onRowToggle,
}: PositionGapRowsProps) {
const capped = Math.min(count, GAP_ROW_LIMIT)
Expand Down Expand Up @@ -1875,8 +1866,6 @@ const PositionGapRows = React.memo(
prev.firstRowUnderHeader !== next.firstRowUnderHeader ||
prev.onCellMouseDown !== next.onCellMouseDown ||
prev.onCellMouseEnter !== next.onCellMouseEnter ||
prev.onRowMouseDown !== next.onRowMouseDown ||
prev.onRowMouseEnter !== next.onRowMouseEnter ||
prev.onRowToggle !== next.onRowToggle
) {
return false
Expand Down Expand Up @@ -1923,11 +1912,8 @@ interface DataRowProps {
onContextMenu: (e: React.MouseEvent, row: TableRowType) => void
onCellMouseDown: (rowIndex: number, colIndex: number, shiftKey: boolean) => void
onCellMouseEnter: (rowIndex: number, colIndex: number) => void
onRowMouseDown: (rowIndex: number, shiftKey: boolean) => void
onRowMouseEnter: (rowIndex: number) => void
isRowChecked: boolean
onRowToggle: (rowIndex: number, shiftKey: boolean) => void
onClearSelection: () => void
}

function rowSelectionChanged(
Expand Down Expand Up @@ -1976,11 +1962,8 @@ function dataRowPropsAreEqual(prev: DataRowProps, next: DataRowProps): boolean {
prev.onContextMenu !== next.onContextMenu ||
prev.onCellMouseDown !== next.onCellMouseDown ||
prev.onCellMouseEnter !== next.onCellMouseEnter ||
prev.onRowMouseDown !== next.onRowMouseDown ||
prev.onRowMouseEnter !== next.onRowMouseEnter ||
prev.isRowChecked !== next.isRowChecked ||
prev.onRowToggle !== next.onRowToggle ||
prev.onClearSelection !== next.onClearSelection
prev.onRowToggle !== next.onRowToggle
) {
return false
}
Expand Down Expand Up @@ -2016,10 +1999,7 @@ const DataRow = React.memo(function DataRow({
onContextMenu,
onCellMouseDown,
onCellMouseEnter,
onRowMouseDown,
onRowMouseEnter,
onRowToggle,
onClearSelection,
}: DataRowProps) {
const sel = normalizedSelection
const isMultiCell = sel !== null && (sel.startRow !== sel.endRow || sel.startCol !== sel.endCol)
Expand Down
Loading