Skip to content

improvement(tables): tables multi-select, keyboard shortcuts, and docs #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 11 commits into from
Mar 17, 2026
Merged

improvement(tables): tables multi-select, keyboard shortcuts, and docs #3615

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
11fce3b
added docs for tables
waleedlatif1 Mar 16, 2026
3e4241c
fix: remove generated files and move image to correct path
waleedlatif1 Mar 16, 2026
f326b05
fix(tables): skip gap positions in handleCopy for checked rows
waleedlatif1 Mar 16, 2026
e25770b
fix(tables): remove dead props from DataRow and PositionGapRows
waleedlatif1 Mar 17, 2026
116648b
fix(tables): clear range selection on Shift+Space to prevent mixed state
waleedlatif1 Mar 17, 2026
4ea4490
fix(tables): remove dead handleRowMouseDown and handleRowMouseEnter
waleedlatif1 Mar 17, 2026
29c765c
fix(tables): move Escape and Cmd+A above anchor guard
waleedlatif1 Mar 17, 2026
3e51e1c
fix(tables): Shift+Space preserves anchor for continued keyboard use
waleedlatif1 Mar 17, 2026
ad34616
fix(tables): only add real row positions in shift-click range select
waleedlatif1 Mar 17, 2026
57d7f76
fix(tables): Delete/Backspace works after Cmd+A select all
waleedlatif1 Mar 17, 2026
4c16333
docs(tables): clarify Delete/Backspace clears all columns in checkbox…
waleedlatif1 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(tables): Shift+Space preserves anchor for continued keyboard use 
Previously Shift+Space cleared selectionAnchor, making all subsequent
keyboard shortcuts (arrows, enter, tab) inoperable until a cell was
clicked. Now it preserves the anchor and only clears focus, so users
can arrow-navigate and Shift+Space to toggle multiple rows in sequence.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
  • Loading branch information
@waleedlatif1 @claude
waleedlatif1 and claude committed Mar 17, 2026
commit 3e51e1c9aa90353002001d05e4f899a08cc99716
35 changes: 18 additions & 17 deletions apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,24 @@ export function Table({
return
}

if (e.key === ' ' && e.shiftKey) {
const a = selectionAnchorRef.current
if (!a || editingCellRef.current) return
e.preventDefault()
setSelectionFocus(null)
setCheckedRows((prev) => {
const next = new Set(prev)
if (next.has(a.rowIndex)) {
next.delete(a.rowIndex)
} else {
next.add(a.rowIndex)
}
return next
})
lastCheckboxRowRef.current = a.rowIndex
return
Comment on lines +722 to +737
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Shift+Space can add gap-row positions to checkedRows

a.rowIndex is the row coordinate from selectionAnchor, which is valid for any grid position — including gap positions that have no corresponding entry in positionMap. When the user navigates to a gap row and presses Shift+Space, that position is unconditionally added to checkedRows:

setCheckedRows((prev) => {
  const next = new Set(prev)
  if (next.has(a.rowIndex)) {
    next.delete(a.rowIndex)
  } else {
    next.add(a.rowIndex)   // gap position added here
  }
  return next
})

The downstream operations (copy, cut, delete) all gate on pMap.get(pos) and skip gaps, so no data corruption occurs. However, the gap row's checkbox will render as visually checked (because checkedRows.has(position) is true in PositionGapRows), and the gap position inflates checkedRows.size. This means isAllRowsSelected can under-count (checkedRows.size >= rows.length might be true while some real rows aren't checked because the set is padded with phantom positions).

Consider guarding with a positionMap lookup:

Suggested change
if (e.key === ' ' && e.shiftKey) {
const a = selectionAnchorRef.current
if (!a || editingCellRef.current) return
e.preventDefault()
setSelectionFocus(null)
setCheckedRows((prev) => {
const next = new Set(prev)
if (next.has(a.rowIndex)) {
next.delete(a.rowIndex)
} else {
next.add(a.rowIndex)
}
return next
})
lastCheckboxRowRef.current = a.rowIndex
return
if (e.key === ' ' && e.shiftKey) {
const a = selectionAnchorRef.current
if (!a || editingCellRef.current) return
e.preventDefault()
setSelectionFocus(null)
const pMap = positionMapRef.current
if (!pMap.has(a.rowIndex)) return
setCheckedRows((prev) => {

}
Comment thread
waleedlatif1 marked this conversation as resolved.

const anchor = selectionAnchorRef.current
if (!anchor || editingCellRef.current) return

Expand Down Expand Up @@ -773,23 +791,6 @@ export function Table({
return
}

if (e.key === ' ' && e.shiftKey) {
e.preventDefault()
setSelectionAnchor(null)
setSelectionFocus(null)
setCheckedRows((prev) => {
const next = new Set(prev)
if (next.has(anchor.rowIndex)) {
next.delete(anchor.rowIndex)
} else {
next.add(anchor.rowIndex)
}
return next
})
lastCheckboxRowRef.current = anchor.rowIndex
return
}

if (e.key === 'Tab') {
e.preventDefault()
setCheckedRows((prev) => (prev.size === 0 ? prev : EMPTY_CHECKED_ROWS))
Expand Down
Loading