Skip to content

improvement(knowledge): make connector-synced document chunks readonly #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Mar 6, 2026
Merged

improvement(knowledge): make connector-synced document chunks readonly #3440

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c12506a
improvement(knowledge): make connector-synced document chunks readonly
waleedlatif1 Mar 6, 2026
70e286f
fix(knowledge): enforce connector chunk readonly on server side
waleedlatif1 Mar 6, 2026
bc504ba
fix(knowledge): disable toggle and delete actions for connector-synce…
waleedlatif1 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(knowledge): disable toggle and delete actions for connector-synce… 
…d chunks
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 6, 2026
commit bc504ba9560aa704383c83236a4dc62f90796825
35 changes: 20 additions & 15 deletions apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,7 +838,8 @@ export function Document({
onCheckedChange={handleSelectAll}
disabled={
documentData?.processingStatus !== 'completed' ||
!userPermissions.canEdit
!userPermissions.canEdit ||
isConnectorDocument
}
aria-label='Select all chunks'
/>
Expand Down Expand Up @@ -925,7 +926,7 @@ export function Document({
onCheckedChange={(checked) =>
handleSelectChunk(chunk.id, checked as boolean)
}
disabled={!userPermissions.canEdit}
disabled={!userPermissions.canEdit || isConnectorDocument}
aria-label={`Select chunk ${chunk.chunkIndex}`}
onClick={(e) => e.stopPropagation()}
/>
Expand Down Expand Up @@ -965,7 +966,7 @@ export function Document({
e.stopPropagation()
handleToggleEnabled(chunk.id)
}}
disabled={!userPermissions.canEdit}
disabled={!userPermissions.canEdit || isConnectorDocument}
className='h-[28px] w-[28px] p-0 text-[var(--text-muted)] hover:text-[var(--text-primary)] disabled:opacity-50'
>
{chunk.enabled ? (
Expand All @@ -978,9 +979,11 @@ export function Document({
<Tooltip.Content side='top'>
{!userPermissions.canEdit
? 'Write permission required to modify chunks'
: chunk.enabled
? 'Disable Chunk'
: 'Enable Chunk'}
: isConnectorDocument
? 'Connector-synced chunks are read-only'
: chunk.enabled
? 'Disable Chunk'
: 'Enable Chunk'}
</Tooltip.Content>
</Tooltip.Root>
<Tooltip.Root>
Expand All @@ -991,7 +994,7 @@ export function Document({
e.stopPropagation()
handleDeleteChunk(chunk.id)
}}
disabled={!userPermissions.canEdit}
disabled={!userPermissions.canEdit || isConnectorDocument}
className='h-[28px] w-[28px] p-0 text-[var(--text-muted)] hover:text-[var(--text-error)] disabled:opacity-50'
>
<Trash className='h-[14px] w-[14px]' />
Expand All @@ -1000,7 +1003,9 @@ export function Document({
<Tooltip.Content side='top'>
{!userPermissions.canEdit
? 'Write permission required to delete chunks'
: 'Delete Chunk'}
: isConnectorDocument
? 'Connector-synced chunks are read-only'
: 'Delete Chunk'}
</Tooltip.Content>
</Tooltip.Root>
</div>
Expand Down Expand Up @@ -1122,9 +1127,9 @@ export function Document({
{/* Bulk Action Bar */}
<ActionBar
selectedCount={selectedChunks.size}
onEnable={disabledCount > 0 ? handleBulkEnable : undefined}
onDisable={enabledCount > 0 ? handleBulkDisable : undefined}
onDelete={handleBulkDelete}
onEnable={disabledCount > 0 && !isConnectorDocument ? handleBulkEnable : undefined}
onDisable={enabledCount > 0 && !isConnectorDocument ? handleBulkDisable : undefined}
onDelete={!isConnectorDocument ? handleBulkDelete : undefined}
enabledCount={enabledCount}
disabledCount={disabledCount}
isLoading={isBulkOperating}
Expand Down Expand Up @@ -1205,7 +1210,7 @@ export function Document({
: undefined
}
onToggleEnabled={
contextMenuChunk && userPermissions.canEdit
contextMenuChunk && userPermissions.canEdit && !isConnectorDocument
? selectedChunks.size > 1
? () => {
if (disabledCount > 0) {
Expand All @@ -1218,7 +1223,7 @@ export function Document({
: undefined
}
onDelete={
contextMenuChunk && userPermissions.canEdit
contextMenuChunk && userPermissions.canEdit && !isConnectorDocument
? selectedChunks.size > 1
? handleBulkDelete
: () => handleDeleteChunk(contextMenuChunk.id)
Expand All @@ -1231,8 +1236,8 @@ export function Document({
? () => setIsCreateChunkModalOpen(true)
: undefined
}
disableToggleEnabled={!userPermissions.canEdit}
disableDelete={!userPermissions.canEdit}
disableToggleEnabled={!userPermissions.canEdit || isConnectorDocument}
disableDelete={!userPermissions.canEdit || isConnectorDocument}
disableAddChunk={
!userPermissions.canEdit ||
documentData?.processingStatus === 'failed' ||
Expand Down