Skip to content

improvement(knowledge): make connector-synced document chunks readonly #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Mar 6, 2026
Merged

improvement(knowledge): make connector-synced document chunks readonly #3440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c12506a
improvement(knowledge): make connector-synced document chunks readonly
waleedlatif1 Mar 6, 2026
70e286f
fix(knowledge): enforce connector chunk readonly on server side
waleedlatif1 Mar 6, 2026
bc504ba
fix(knowledge): disable toggle and delete actions for connector-synce…
waleedlatif1 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(knowledge): enforce connector chunk readonly on server side
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Mar 6, 2026
commit 70e286fdacf86775eabe297bc30e41cac220c24a
20 changes: 20 additions & 0 deletions apps/sim/app/api/knowledge/[id]/documents/[documentId]/chunks/[chunkId]/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,16 @@ export async function PUT(
return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
}

if (accessCheck.document?.connectorId) {
logger.warn(
`[${requestId}] User ${session.user.id} attempted to update chunk on connector-synced document: Doc=${documentId}`
)
return NextResponse.json(
{ error: 'Chunks from connector-synced documents are read-only' },
{ status: 403 }
)
}

const body = await req.json()

try {
Expand Down Expand Up @@ -167,6 +177,16 @@ export async function DELETE(
return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
}

if (accessCheck.document?.connectorId) {
logger.warn(
`[${requestId}] User ${session.user.id} attempted to delete chunk on connector-synced document: Doc=${documentId}`
)
return NextResponse.json(
{ error: 'Chunks from connector-synced documents are read-only' },
{ status: 403 }
)
}

await deleteChunk(chunkId, documentId, requestId)

logger.info(
Expand Down
20 changes: 20 additions & 0 deletions apps/sim/app/api/knowledge/[id]/documents/[documentId]/chunks/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,16 @@ export async function POST(
return NextResponse.json({ error: 'Document not found' }, { status: 404 })
}

if (doc.connectorId) {
logger.warn(
`[${requestId}] User ${userId} attempted to create chunk on connector-synced document: Doc=${documentId}`
)
return NextResponse.json(
{ error: 'Chunks from connector-synced documents are read-only' },
{ status: 403 }
)
}

// Allow manual chunk creation even if document is not fully processed
// but it should exist and not be in failed state
if (doc.processingStatus === 'failed') {
Expand Down Expand Up @@ -283,6 +293,16 @@ export async function PATCH(
return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
}

if (accessCheck.document?.connectorId) {
logger.warn(
`[${requestId}] User ${userId} attempted batch chunk operation on connector-synced document: Doc=${documentId}`
)
return NextResponse.json(
{ error: 'Chunks from connector-synced documents are read-only' },
{ status: 403 }
)
}

const body = await req.json()

try {
Expand Down
4 changes: 4 additions & 0 deletions apps/sim/app/api/knowledge/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ export interface DocumentData {
boolean1?: boolean | null
boolean2?: boolean | null
boolean3?: boolean | null
// Connector fields
connectorId?: string | null
}

export interface EmbeddingData {
Expand Down Expand Up @@ -283,6 +285,8 @@ export async function checkDocumentWriteAccess(
boolean1: document.boolean1,
boolean2: document.boolean2,
boolean3: document.boolean3,
// Connector fields
connectorId: document.connectorId,
})
.from(document)
.where(and(eq(document.id, documentId), isNull(document.deletedAt)))
Expand Down