Skip to content

fix(permissions): add client-side permissions validation to prevent unauthorized actions, upgraded custom tool modal #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Nov 28, 2025
Merged

fix(permissions): add client-side permissions validation to prevent unauthorized actions, upgraded custom tool modal #2130

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c011fe8
fix(permissions): add client-side permissions validation to prevent u…
waleedlatif1 Nov 28, 2025
1eedd35
fix failing test
waleedlatif1 Nov 28, 2025
a83b7ce
fix test
waleedlatif1 Nov 28, 2025
c886f31
cleanup
waleedlatif1 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Nov 28, 2025
commit c886f31b4d69ca5c8343cf4e1e1234a13cb1ecff
8 changes: 5 additions & 3 deletions ...onents/sub-block/components/tool-input/components/custom-tool-modal/custom-tool-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,9 @@ try {
const { data: customTools = [] } = useCustomTools(workspaceId)

useEffect(() => {
if (open && initialValues) {
if (!open) return

if (initialValues) {
try {
setJsonSchema(
typeof initialValues.schema === 'string'
Expand All @@ -285,10 +287,10 @@ try {
logger.error('Error initializing form with initial values:', { error })
setSchemaError('Failed to load tool data. Please try again.')
}
} else if (open) {
} else {
resetForm()
}
}, [open, initialValues])
}, [open])

const resetForm = () => {
setJsonSchema('')
Expand Down