Skip to content

fix(permissions): add client-side permissions validation to prevent unauthorized actions, upgraded custom tool modal #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Nov 28, 2025
Merged

fix(permissions): add client-side permissions validation to prevent unauthorized actions, upgraded custom tool modal #2130

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c011fe8
fix(permissions): add client-side permissions validation to prevent u…
waleedlatif1 Nov 28, 2025
1eedd35
fix failing test
waleedlatif1 Nov 28, 2025
a83b7ce
fix test
waleedlatif1 Nov 28, 2025
c886f31
cleanup
waleedlatif1 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix failing test
  • Loading branch information
@waleedlatif1
waleedlatif1 committed Nov 28, 2025
commit 1eedd358a4b58d98b78a6a4cfed0d23923cb9a5a
4 changes: 3 additions & 1 deletion apps/sim/app/api/chat/manage/[id]/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,10 @@
})

describe('GET', () => {
it('should return 401 when user is not authenticated', async () => {

Check failure on line 96 in apps/sim/app/api/chat/manage/[id]/route.test.ts

View workflow job for this annotation

GitHub Actions / Test and Build / Test and Build

app/api/chat/manage/[id]/route.test.ts > Chat Edit API Route > GET > should return 401 when user is not authenticated 

Error: Test timed out in 5000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ app/api/chat/manage/[id]/route.test.ts:96:5
mockGetSession.mockResolvedValueOnce(null)
vi.doMock('@/lib/auth', () => ({
getSession: vi.fn().mockResolvedValue(null),
}))

const req = new NextRequest('http://localhost:3000/api/chat/manage/chat-123')
const { GET } = await import('@/app/api/chat/manage/[id]/route')
Expand Down
Loading