Now allowing Authsources to set validUntil and cacheDuration for Metadata.#1481
Now allowing Authsources to set validUntil and cacheDuration for Metadata.#1481tommy2d wants to merge 6 commits into
Conversation
thijskh
left a comment
There was a problem hiding this comment.
Needs to be changed according to the (later) changes to the SP metadata refactoring + unit test update so we keep coverage of the new code up to date.
| if ($metadata['expire'] - time() < $this->maxDuration) { | ||
| $this->maxDuration = $metadata['expire'] - time(); | ||
| if ($metadata['expire'] - time() < $this->cacheDuration) { | ||
| $this->cacheDuration = $metadata['expire'] - time(); |
There was a problem hiding this comment.
I don't understand what this code wants to achieve. There is an expiration in the metadata. So we whould likely set validUntil to that value I think? Not cacheDuration? In any case the docs should probably say how the option interacts with expire.
There was a problem hiding this comment.
Agreed.. I think it's also the wrong setting being set here.. Our metadata-converter converts validUntil to expire.
I think it makes sense to drop the expire-option in favour of validUntil.
a96e0bf to
575b81d
Compare
575b81d to
ec3e5ec
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1481 +/- ##
=========================================
Coverage 40.05% 40.05%
- Complexity 3531 3532 +1
=========================================
Files 141 141
Lines 10596 10598 +2
=========================================
+ Hits 4244 4245 +1
- Misses 6352 6353 +1 🚀 New features to boost your workflow:
|
|
I've rebased against |
|
There's still quite a lot of code that refers to expire when talking about remote entities I think. Are you referring to that or to the setting for hosted entities (does that exist?). |
|
It does not exist for hosted entities I think, so for remote entities... |
7a53fc8 to
d73ae47
Compare
e5c0e21 to
d5616df
Compare
2e6ab04 to
32f9acc
Compare
c743c9a to
fc71570
Compare
7b173cf to
3326beb
Compare
8ac729b to
a16cf6e
Compare
fc454de to
7ac76ae
Compare
29f7b69 to
1a911ce
Compare
c7c8357 to
fdbe001
Compare
3b5f5ba to
96357ee
Compare
332c2bb to
a1681a6
Compare
Now allowing generation of SP metadata XML that includes @validuntil or @cacheDuration at EntityDescriptor.