Skip to content

Add guard for depth overflow in ondemand parser #2662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uwezkhan wants to merge 1 commit into from
+1 −0
Closed

Add guard for depth overflow in ondemand parser #2662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/simdjson/generic/ondemand/json_iterator-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ simdjson_warn_unused simdjson_inline error_code json_iterator::skip_child(depth_
switch (*return_current_and_advance()) {
case '[': case '{':
logger::log_start_value(*this, "skip");
if (simdjson_unlikely(_depth == INT32_MAX)) { return report_error(DEPTH_ERROR, "Depth overflow in skip_child"); }
_depth++;
break;
// TODO consider whether matching braces is a requirement: if non-matching braces indicates
Expand Down
Loading