Add guard for depth overflow in ondemand parser#2662
Open
uwezkhan wants to merge 1 commit intosimdjson:masterfrom
Open
Add guard for depth overflow in ondemand parser#2662uwezkhan wants to merge 1 commit intosimdjson:masterfrom
uwezkhan wants to merge 1 commit intosimdjson:masterfrom
Conversation
Member
|
Please demonstrate that an overflow is possible. I don't think it is. |
Contributor
Author
|
You are right that this requires a very large and deeply nested input. However the overflow is still reachable within the documented limits. In that case _depth will wrap and the condition in skip_child() can I agree this is an extreme edge case. The change here is only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check in skip_child() to avoid overflow in depth tracking.
In extreme cases, the depth counter can overflow when parsing
deeply nested input. This adds a guard before incrementing it
and returns an error if the limit is reached.