Suppress error code if copying of README.md/amalgamate_demo.cpp isn't needed - #1103
Conversation
|
|
||
| cp -u "${SCRIPTPATH}/amalgamate_demo.cpp" "${DEMOCPP}" 2>/dev/null | ||
| cp -u "${SCRIPTPATH}/README.md" "${README}" 2>/dev/null | ||
| cp -u "${SCRIPTPATH}/amalgamate_demo.cpp" "${DEMOCPP}" 2>/dev/null || : |
There was a problem hiding this comment.
What does the : do? This is new syntax to me.
Will cp -f do what we want? I don't care which, as long as this works everywhere.
There was a problem hiding this comment.
Also, if the source file isn't there and it therefore fails to copy, will we still get an error code?
There was a problem hiding this comment.
The "-u" flag is GNU-specific. It is likely not to work under freeBSD and macos.
|
Under non-GNU systems (so FreeBSD and macOS)... will only copy simdjson.cpp and simdjson.h. |
|
Please don't use GNU-specific flags. It is bad practice. |
|
Currently the build is broken if you have bash but are not under a GNU system (essentially Linux and the like). We cannot use See PR: |
|
I'll close this PR. If there is still an issue, please generate a new PR. |
Fixes an error introduced by #1070