Do not update README.md and amalgamate_demo.cpp from amalgamate.sh - #1070
Merged
jkeiser merged 1 commit intoAug 6, 2020
Merged
Conversation
pps83
force-pushed
the
bugfix/Do-not-update-README-and-amalgamate_demo
branch
2 times, most recently
from
July 28, 2020 15:14
2c675f7 to
5c31bce
Compare
jkeiser
reviewed
Jul 30, 2020
jkeiser
reviewed
Jul 30, 2020
jkeiser
reviewed
Jul 30, 2020
jkeiser
requested changes
Aug 4, 2020
jkeiser
left a comment
Member
There was a problem hiding this comment.
Just need to copy README and I think we're good. Super glad to see amalgamate_demo.cpp become static.
README.md and amalgamate_demo.cpp are always the same, there is no point to keep a copy and recreate them from amalgamate.sh
pps83
force-pushed
the
bugfix/Do-not-update-README-and-amalgamate_demo
branch
from
August 6, 2020 03:11
5c31bce to
352eb4c
Compare
Contributor
Author
updated |
Member
|
@jkeiser wrong person :P |
Member
|
:embarrassed: @pps83 thank you :) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md and amalgamate_demo.cpp are always the same, there is no point to keep a copy and recreate them from amalgamate.sh