Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 12, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ln(source, existingDestination)reportsDestination file existsbut then continues tounlinkSync()and replaces the destination anyway. Without-f, this can overwrite a regular file, replace an existing symlink, or delete the source itself when source and destination are the same path.Stop the command at the existing-destination error. The returned failure status/message and explicit
-f/-sfbehavior are preserved.Tests strengthen the existing destination check and add nine cases covering regular files, symlink destinations, missing sources, self-links, fatal mode and a dangling-link control.
Validation on Linux / Node.js 24.19.0:
npm testand coverage runs: 649 passed / 6 existing skips each.check-node-support, generated-documentation consistency andgit diff --checkpass.lndifferential scenarios pass, including inode/content preservation and explicit force controls.The six existing explicit skips are in
cmd.js: five async cases and the missing-exec-path case. Native Windows/macOS and other Node versions were not run locally; symlink-setup cases use the project's existing Windows skip helper.This addresses rejection of an existing destination without
-f, separately from the forced dangling-symlink behavior in #1281 and directory-destination support in #833. No existing issue is claimed closed.Prepared and tested with AI assistance (OpenAI Codex). No human review is claimed.