Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1039
ln -sfandln -fnow replace a destination that is a broken symlink. Before, they failed withln: EEXIST. Realln -sfreplaces it.src/ln.jscheckeddestwithfs.existsSync, which follows links, so a broken symlink looked absent. The-funlink was skipped andfs.symlinkSyncthrewEEXIST. The check now usescommon.statNoFollowLinks(lstat). Regular files, directories and valid symlinks are unaffected, becausefs.existsSyncalready returned true for them.Without
-f, a broken-symlink destination now givesDestination file exists, the same as any other existing destination, instead of the rawEEXISTmessage.I used try/catch on
statNoFollowLinksbecauserm.jsandcp.jsuse the same pattern to check existence without following links.fs.existsSync(dest) || <lstat>.isSymbolicLink()also works. I can change to that if you prefer it.The new test
-sf option on existing broken symlinkintest/ln.jsuses thetest/resources/badlinkfixture. It fails on master with theEEXISTerror from the issue and passes with this change.