fix: fix typings for queries with {plain: true} option#13899
Merged
Conversation
Contributor
Author
|
I guess it should wait for #13870 to be merged |
Member
Don't worry about that. The tests are re-running, but we can approve this PR without disabling the flaky test |
Contributor
Author
ok its all good then ? |
fzn0x
approved these changes
Jan 5, 2022
ephys
approved these changes
Jan 5, 2022
Member
|
Tested and looks good to me. Now it's just a question of merging :) |
sdepold
pushed a commit
that referenced
this pull request
Jan 10, 2022
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> Co-authored-by: fncolon <fncolon@pm.me>
Contributor
|
🎉 This PR is included in version 7.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
aliatsis
pushed a commit
to creditiq/sequelize
that referenced
this pull request
Jun 2, 2022
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com> Co-authored-by: fncolon <fncolon@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Change
Add null to returned Promise when querying with {plain: true}