Codecov Report

Merging #12585 (fd035e2) into main (490db41) will not change coverage.
The diff coverage is n/a.

❗ Current head fd035e2 differs from pull request most recent head 6efef59. Consider uploading reports for the commit 6efef59 to get more accurate results

@@           Coverage Diff           @@
##             main   #12585   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          95       95           
  Lines        9162     9162           
=======================================
  Hits         8836     8836           
  Misses        326      326           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 490db41...6efef59. Read the comment docs.

I will be looking forward to this, thanks

UP ?

fixed I believe

nope was fixed for before/after upsert
still missing the null return

        query<M extends Model>(sql: string | { query: string; values: unknown[] }, options: QueryOptionsWithModel<M> & { plain: true }): Promise<M | null>;```

Sorry for taking so long to review this.

I'm going around old TS PRs to merge them.

The plain query typing was fixed in your other PR #13899
@arsonik can you resolve the conflict?

Can you also add a test in types/test to prevent regressions?
Simply call those methods with the right signature.

Hi @arsonik, why did you close the PR?

Hi @arsonik, why did you close the PR?

Because a more recent PR that fixes the issue was merged

#13899

Oh I didn't notice you closed this PR. It's still interesting for the afterUpsert/beforeUpsert part :)

because that PR was merged
#13394

Aaah! Thanks :)