Skip to content

Disable cascading rules by default#1347

Merged
Ilyesbdlala merged 4 commits into
mainfrom
maintenance/disable-cascading-rules-by-default
Sep 29, 2022
Merged

Disable cascading rules by default#1347
Ilyesbdlala merged 4 commits into
mainfrom
maintenance/disable-cascading-rules-by-default

Conversation

@the-simmon

@the-simmon the-simmon commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

solves #914

@the-simmon the-simmon added maintenance breaking Changes requiring a major release cascading-scans planned Issues we will do in the next sprint. labels Sep 7, 2022
@the-simmon the-simmon self-assigned this Sep 7, 2022
@the-simmon the-simmon linked an issue Sep 7, 2022 that may be closed by this pull request
Stop installing cascading scan rules by default? #914
Closed
@github-actions

github-actions Bot commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ SPELL misspell 16 0 0.05s
✅ YAML prettier 16 0 0.95s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@malexmave

malexmave commented Sep 7, 2022

Copy link
Copy Markdown
Member

Don't forget to also change the template and double-check the example files in the documentation.

@malexmave

malexmave commented Sep 7, 2022

Copy link
Copy Markdown
Member

And double-check that the helm docs are also regenerated correctly, as this change should also change the README.md.

@malexmave malexmave added this to the v4.0.0 milestone Sep 7, 2022
@Ilyesbdlala Ilyesbdlala mentioned this pull request Sep 29, 2022
Merged
the-simmon and others added 4 commits September 29, 2022 18:26
@the-simmon @Ilyesbdlala
Disable cascading rules by default
52d9c48 
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@the-simmon @Ilyesbdlala
Enable cascading rules for cascading hook tests
3bcf45e 
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
@Ilyesbdlala
chore(template): Changed the template to set cascadingrules.enabled t…
426c9f3 
…o false by default

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
docs(cascading-scan): Added Upgrading note to set cascadingrules.enab…
9769cb8 
…led to true explicitly

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala force-pushed the maintenance/disable-cascading-rules-by-default branch from 57a26a1 to 9769cb8 Compare September 29, 2022 16:44
Ilyesbdlala
Ilyesbdlala approved these changes Sep 29, 2022
View reviewed changes

@Ilyesbdlala Ilyesbdlala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added needed upgrading notes and created relevant PR that modifies the how-to of cascading scans correspondingly secureCodeBox/documentation#279.

@Ilyesbdlala

Ilyesbdlala commented Sep 29, 2022

Copy link
Copy Markdown
Member

And double-check that the helm docs are also regenerated correctly, as this change should also change the README.md.

Running helm docs manually on the branches is no longer necessary, as they have become since #1291 able to run on and commit to the main branch.

@Ilyesbdlala Ilyesbdlala merged commit c611b8a into main Sep 29, 2022
@Ilyesbdlala Ilyesbdlala deleted the maintenance/disable-cascading-rules-by-default branch September 29, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ilyesbdlala Ilyesbdlala Ilyesbdlala approved these changes

Assignees

@the-simmon the-simmon

Labels

breaking Changes requiring a major release cascading-scans maintenance planned Issues we will do in the next sprint.

Projects

secureCodeBox
Archived in project

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Stop installing cascading scan rules by default?

3 participants

@the-simmon @malexmave @Ilyesbdlala