Skip to content

Run Helm docs generation only on main branch#1291

Merged
rfelber merged 1 commit into
mainfrom
maintenance/helm-on-main-push-only
Sep 2, 2022
Merged

Run Helm docs generation only on main branch#1291
rfelber merged 1 commit into
mainfrom
maintenance/helm-on-main-push-only

Conversation

@Ilyesbdlala

@Ilyesbdlala Ilyesbdlala commented Jul 28, 2022

Copy link
Copy Markdown
Member

Description

Changed the trigger to only the main branch.
To allow pushing to main. a PAT with admin privileges is required.
secrets.PAT_WITH_ADMIN is currently a placeholder.
closes https://github.com/secureCodeBox/internal/issues/62

A different “solution” would be to disable PGP signing for the helm-bot. This would no longer require access to main repo secrets and allow helm-bot to run on forks.

I tried the suggestions mentioned in the git-auto-commit Action documentation. AFAIK, they do not fit our use-case. (#1294)

Changed the trigger to only the main branch.
To allow pushing to main. a PAT with admin privileges is required.
secrets.PAT_WITH_ADMIN is currently a placeholder.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@github-actions

github-actions Bot commented Jul 28, 2022

Copy link
Copy Markdown

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.04s
✅ GIT git_diff yes no 0.17s
✅ SPELL misspell 1 0 0.03s
⚠️ YAML prettier 1 1 0.56s
✅ YAML v8r 1 0 1.43s
✅ YAML yamllint 1 0 0.13s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@rfelber rfelber added this to the v3.15.0 milestone Aug 31, 2022
@rfelber rfelber marked this pull request as ready for review September 2, 2022 15:29
@rfelber rfelber merged commit 4953225 into main Sep 2, 2022
@rfelber rfelber deleted the maintenance/helm-on-main-push-only branch September 2, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants