Skip to content

More MockResolver tests #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkropachev merged 1 commit into from
Sep 9, 2024
Merged

More MockResolver tests #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/java/com/datastax/oss/driver/internal/core/resolver/ResolverProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.datastax.oss.driver.internal.core.resolver;

import com.datastax.oss.driver.internal.core.resolver.defaultResolver.DefaultResolverFactory;
import com.datastax.oss.driver.shaded.guava.common.annotations.VisibleForTesting;

/**
* Entry point for driver components to getting the {@link Resolver} instances. By default returns
Expand Down Expand Up @@ -45,4 +46,10 @@ public static synchronized void setDefaultResolverFactory(
alreadySet = true;
defaultResolverFactoryImpl = resolverFactoryImpl;
}

@VisibleForTesting
static synchronized void resetBooleansForTesting() {
alreadyInUse = false;
alreadySet = false;
}
}
52 changes: 52 additions & 0 deletions core/src/test/java/com/datastax/oss/driver/internal/core/resolver/ResolverProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
package com.datastax.oss.driver.internal.core.resolver;

import static org.assertj.core.api.AssertionsForClassTypes.assertThat;

import com.datastax.oss.driver.internal.core.resolver.mockResolver.MockResolverFactory;
import org.junit.Before;
import org.junit.Test;

public class ResolverProviderTest {

@Before
public void resetState() {
ResolverProvider.resetBooleansForTesting();
}

@Test(expected = IllegalStateException.class)
public void should_not_allow_setting_twice() {
try {
MockResolverFactory first = new MockResolverFactory();
MockResolverFactory second = new MockResolverFactory();
ResolverProvider.setDefaultResolverFactory(first);
ResolverProvider.setDefaultResolverFactory(second);
} catch (IllegalStateException ex) {
assertThat(ex.getMessage())
.isEqualTo(
"Cannot change default resolver factory: this method has already been called. You can set "
+ "default resolver factory only once.");
throw ex;
}
}

@Test(expected = IllegalStateException.class)
public void should_not_allow_setting_once_in_use() {
try {
ResolverProvider.getResolver(ResolverProviderTest.class);
MockResolverFactory first = new MockResolverFactory();
ResolverProvider.setDefaultResolverFactory(first);
} catch (IllegalStateException ex) {
assertThat(ex.getMessage())
.isEqualTo(
"Cannot change default resolver factory: ResolverProvider has already returned an instance of a "
+ "Resolver to use. Default resolver factory needs to be set up before first use by any class.");
throw ex;
}
}

@Test
public void should_allow_setting_once() {
MockResolverFactory first = new MockResolverFactory();
ResolverProvider.setDefaultResolverFactory(first);
}
}