Skip to content

More MockResolver tests#337

Merged
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
Bouncheck:scylla-4.x-mockResolver-extra-tests-3
Sep 9, 2024
Merged

More MockResolver tests#337
dkropachev merged 1 commit into
scylladb:scylla-4.xfrom
Bouncheck:scylla-4.x-mockResolver-extra-tests-3

Conversation

@Bouncheck

Copy link
Copy Markdown

Adds one more integartion test method and unit tests for ResolverProvider
Applied on top of #335

@Bouncheck Bouncheck force-pushed the scylla-4.x-mockResolver-extra-tests-3 branch from 09c069f to 52fe4b7 Compare September 4, 2024 15:08
@Bouncheck Bouncheck force-pushed the scylla-4.x-mockResolver-extra-tests-3 branch from 52fe4b7 to 61b4ef7 Compare September 4, 2024 15:33
@dkropachev

Copy link
Copy Markdown

@Bouncheck , let's rebase it and continue working on it

@dkropachev

Copy link
Copy Markdown

@Bouncheck , ping

@Bouncheck Bouncheck force-pushed the scylla-4.x-mockResolver-extra-tests-3 branch from 61b4ef7 to eb3faa2 Compare September 9, 2024 11:58
@Bouncheck Bouncheck marked this pull request as ready for review September 9, 2024 12:18
@Bouncheck Bouncheck self-assigned this Sep 9, 2024
@Bouncheck

Bouncheck commented Sep 9, 2024

Copy link
Copy Markdown
Author

Looks like with some cluster versions the test manages to restart cluster 17-27 times before it runs out of time to reproduce the socket replacement issue. Maybe I should remove @Test from it and just have it like that as a reproducer for later?

@dkropachev

dkropachev commented Sep 9, 2024

Copy link
Copy Markdown

@Bouncheck , let's remove cannot_reconnect_with_resolved_socket from this PR, and create another PR to address this particular issue, that is going include fix for it, and mark test to be skipped with message that describes what test does and why we need it there.

@Bouncheck Bouncheck force-pushed the scylla-4.x-mockResolver-extra-tests-3 branch from eb3faa2 to d427778 Compare September 9, 2024 13:59
@Bouncheck

Copy link
Copy Markdown
Author

Removed

@Bouncheck Bouncheck requested a review from dkropachev September 9, 2024 14:54
@dkropachev dkropachev merged commit d642afa into scylladb:scylla-4.x Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants