Skip to content

Replcommands#726

Merged
khellang merged 20 commits into
scriptcs:devfrom
adamralph:replcommands
May 30, 2014
Merged

Replcommands#726
khellang merged 20 commits into
scriptcs:devfrom
adamralph:replcommands

Conversation

@adamralph
Copy link
Copy Markdown
Contributor

I tried merging latest dev into the existing replcommands branch but it ended up in a massive merge commit and it was just too difficult to work with WRT diff'ing the history etc. so I went back to the original branch, rebased it, and cherry picked the three post-merge commits (ignoring the last commit which introduced the Arguments class).

This branch is now a straight line of commits from dev.

The syntax changes that came out of our discussions have now been implemented.

closes #224
closes #237
closes #583

replaces #612

@adamralph adamralph added the hold label May 29, 2014
filipw and others added 20 commits May 30, 2014 16:57
…maintain the references correctly. This not an ideal fix at this moment as it requires copying the list of references over and over, but if we move to refactor the ScriptEngine we will address it anyway - this is out of scope here.
…string

change Repl.Commands to IEnumerable
relaxed AssemblyReferences.ctor and made fields readonly
add Guards
removed redundant code
tidied up formatting

#224
#237
#583
…ateStrings, ShouldSurfaceArgumentCompilationErrors, ShouldSurfaceArgumentExecutionErrors, ShouldSurfaceIncompleteArguments

removed ShouldPassArgsToCommand, ShouldUseObjectIfArgCanBeEvaluatedToValue

#224
#237
#583
…aceArgumentExecutionErrors, ShouldSurfaceIncompleteArguments

#224
#237
#583
@adamralph adamralph removed the hold label May 30, 2014
@adamralph
Copy link
Copy Markdown
Contributor Author

rebased and ready to go!

@khellang
Copy link
Copy Markdown
Member

Alright.. here it goes! 👯 ✨

khellang added a commit that referenced this pull request May 30, 2014
@khellang khellang merged commit 4e86ef0 into scriptcs:dev May 30, 2014
@khellang khellang mentioned this pull request May 30, 2014
@khellang
Copy link
Copy Markdown
Member

I'm not really sure we need to reference each issue for each commit. It creates a shitload of noise:

asd

If they're all part of a PR, I think it's enough to reference the issues in the PR, as you've done here. Just my 2¢ 😄

@adamralph adamralph deleted the replcommands branch May 30, 2014 15:39
@adamralph
Copy link
Copy Markdown
Contributor Author

fair point 😃

but... it's in! 😂

@ztone
Copy link
Copy Markdown
Contributor

ztone commented May 30, 2014

Yes, finally 😄 🍻

@khellang
Copy link
Copy Markdown
Member

Who wants to take on the responsibility and blog this? 😉

@khellang khellang added this to the v0.10 milestone Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using scriptcs as a liveable shell? Add pluggable command infra for the REPL REPL - Basic Commands

4 participants