Replcommands#726
Merged
Merged
Conversation
…maintain the references correctly. This not an ideal fix at this moment as it requires copying the list of references over and over, but if we move to refactor the ScriptEngine we will address it anyway - this is out of scope here.
Contributor
Author
|
rebased and ready to go! |
Member
|
Alright.. here it goes! 👯 ✨ |
Member
Contributor
Author
|
fair point 😃 but... it's in! 😂 |
Contributor
|
Yes, finally 😄 🍻 |
Member
|
Who wants to take on the responsibility and blog this? 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I tried merging latest
devinto the existingreplcommandsbranch but it ended up in a massive merge commit and it was just too difficult to work with WRT diff'ing the history etc. so I went back to the original branch, rebased it, and cherry picked the three post-merge commits (ignoring the last commit which introduced the Arguments class).This branch is now a straight line of commits from dev.
The syntax changes that came out of our discussions have now been implemented.
closes #224
closes #237
closes #583
replaces #612