Skip to content

Custom Properties: forms.css#28

Open
danfarrow wants to merge 8 commits into
ryelle:try/custom-propertiesfrom
danfarrow:try/custom-properties
Open

Custom Properties: forms.css#28
danfarrow wants to merge 8 commits into
ryelle:try/custom-propertiesfrom
danfarrow:try/custom-properties

Conversation

@danfarrow
Copy link
Copy Markdown

Starting a new PR because I got in a total git tangle with my previous one, sorry!

…es, move button styles to the button.css file
@ryelle
Copy link
Copy Markdown
Owner

ryelle commented Sep 22, 2021

@danfarrow I started reviewing & moving around some properties before I realized the file wasn't completely finished yet 😅 I hope you don't mind that I pushed my changes to this branch. Let me know when you're done with the file (or if you want to hand it off), and I'll pick up my review again.

@ryelle ryelle added the [Status] In Progress PR author is still working on this label Sep 22, 2021
@danfarrow
Copy link
Copy Markdown
Author

@ryelle Thanks for the review! I was planning to address the rgba & box-shadow values, however my local repo is currently in a mess which I’m trying to sort out. Please let me know if I’m holding up progress!

@danfarrow
Copy link
Copy Markdown
Author

@ryelle I realised I still had some hex values in forms.css which I have now updated and pushed. However my PR now has a bunch of other core updates which I didn’t intend to include! Currently trying to figure out how to remedy this

@danfarrow danfarrow force-pushed the try/custom-properties branch 2 times, most recently from 6311d9e to 8b9c8d0 Compare September 30, 2021 20:38
@danfarrow
Copy link
Copy Markdown
Author

@ryelle I’ve cleaned up now (with invaluable assistance from @hellofromtonya!) I have yet to address the rgba values but will be doing that next.

@danfarrow
Copy link
Copy Markdown
Author

rgba values are now converted to custom props - I think this PR is now ready to merge

@ryelle ryelle removed the [Status] In Progress PR author is still working on this label Oct 8, 2021
@ryelle ryelle changed the title Try/custom properties Custom Properties: forms.css Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants