Adding custom properties to forms.css#23
Conversation
forms.css
|
All hex colour values now changed to custom properties, and all custom properties moved to the bottom of I used the prefix My strategy for deciding to either (A) use an existing custom-prop, (B) add a new custom prop aliasing an existing custom-prop or (C) use a new custom prop with the same value as an existing custom prop was a little random, so there are a couple of instances of (C) in the props I’ve added. I’ve ignored |
| textarea:focus { | ||
| border-color: #2271b1; | ||
| box-shadow: 0 0 0 1px #2271b1; | ||
| border-color: var(--wp-admin--form-fields--border--focus); |
There was a problem hiding this comment.
@danfarrow is there a reason for separating --wp-admin--form-fields--border--focus and --wp-admin-theme-primary in this selector declaration?
There was a problem hiding this comment.
No there is no special reason, I think at that point I hadn’t decided whether to make aliases or not. I will try & remedy it!
|
Closing this due to git confusion on my part. I’ve opened a new PR here #28 |
Working on adding custom properties to
forms.css. I’ll move my new properties intocustom-properties.cssonce I’ve finished adding themTrac ticket: #49930 - Replace wp-admin color schemes with CSS custom properties
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.