Add SocketAcceptorInterceptor#676
Merged
Merged
Conversation
This commit deprecates the client side acceptor(BiFunction<ConnectionSetupPayload, RSocket>) and adds support for SocketAcceptor instead. This makes it possible for a client side acceptor to be asynchronous too, and allows applying the same acceptor both client and server side. Signed-off-by: Rossen Stoyanchev <rstoyanchev@pivotal.io>
This commit adds an interceptor for SocketAcceptor. This provides access to connection setup information and also allows applying requester and responder interceptors from one place. Signed-off-by: Rossen Stoyanchev <rstoyanchev@pivotal.io>
rstoyanchev
force-pushed
the
interceptor
branch
from
August 2, 2019 11:20
ce0de97 to
9cdccef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently an
RSocketInterceptorcan only intercept requests, but has no visibility into connection setup like metadata and data mime types, see #661 (comment). Especially on the server side there is no way for an interceptor to access this information which can be critical (e.g. for a security interceptor).This pull request adds
SocketAcceptorInterceptorand also updates support forSocketAcceptorso both are supported symmetrically.