Meta: use refs for tooltips in JSX#9845
Merged
Merged
Conversation
fregante
marked this pull request as ready for review
July 17, 2026 12:00
Member
Author
|
Tested and it works |
Contributor
Member
Author
|
I realized this pattern also makes it easier to toggle between the two types of Not now though |
Member
Author
|
Yoloing copilot's changes, the util seems to work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Easier way to add tooltips to any element, without having to break the JSX with
<El>{tooltipped('tip', <Inner/>)}</El>I'd replace all
tooltipped()usage but I don't want to have to manually check each instance again:Plus I have a few components I need to turn into Svelte first: