Update tooltips style to integrate better by Copilot · Pull Request #9451 · refined-github/refined-github

Copilot · 2026-05-13T16:19:35Z

I am a tool

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/879d9526-be69-4dcd-b9df-5f402298a4b9 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fregante · 2026-05-13T16:25:27Z

+	addToolTip({
+		label: 'Close as not planned.\nWon’t fix, can’t repro, duplicate, stale',
+		direction: 'nw',
+	}, unplannedButton);


It's looking pretty good. I'll just have to verify that these all work

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/548e4a42-b2a9-48bc-9fcc-c14b4d93843f Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/34ab5d27-c768-4348-9f21-e8b1f67a7d17 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

…label-with-tooltip

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/b1af5a61-e585-4947-af3f-dc6d7c219c5d Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/896f2162-0331-43d8-8a4d-46a727db5113 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fregante

Code looks good so far. Not completely tested.

I had to undo a couple of features because they were too messy.

These new helpers aren't necessarily better than what we had, they just look good when hotkeys are involved and when there are some overlap or ::before issues

fregante · 2026-05-13T17:39:41Z

+	addToolTip({
+		label: 'Open unread notifications',
+		shortcut: 'g u',
+		direction: 'sw',
+	}, button);


😍

Before After

SunsetTechuila · 2026-05-13T17:57:56Z

We also should remove now redundant overflow: visible rules like this one: https://github.com/refined-github/refined-github/blob/ed3769c89128b6e4119fafd29b729d8d744c1c55/source/features/jump-to-conversation-close-event.css

…label-with-tooltip

fregante

oof, it had been a while since I had to verify this many features at once. The PR works, even if there are a lot of bugs I found along the way. Some tooltips should probably be repositioned, they don't look great.

direction=s is best. I think tool-tip avoids causing viewport overflows, clippings, and z-index flights, so most of the reasons why we chose alternative positioning should be reviewed.

fregante · 2026-05-14T11:02:23Z

@@ -10,6 +10,7 @@ import api from '../github-helpers/api.js';
 import {expectToken} from '../github-helpers/github-token.js';


https://github.com/refined-github/refined-github/pulls

fregante · 2026-05-14T11:03:10Z

@@ -15,6 +15,7 @@ import {fixFileHeaderOverlap, isRepoCommitListRoot} from '../github-helpers/inde
 import isDefaultBranch from '../github-helpers/is-default-branch.js';


https://github.com/refined-github/refined-github/tree/Safari

fregante · 2026-05-14T11:04:07Z

@@ -11,6 +11,7 @@ import {expectToken} from '../github-helpers/github-token.js';
 import {cacheByRepo} from '../github-helpers/index.js';


https://github.com/refined-github/refined-github/actions

https://github.com/facebook/react/actions

Also opened

github-actions-indicators misplaced when you don't have access #9454

fregante · 2026-05-14T11:09:07Z

@@ -10,6 +10,7 @@ import {$, $$, $$optional, $closest, $optional} from 'select-dom';
 import features from '../feature-manager.js';


highest-rated-comment broken on new issue UI #9271

fregante · 2026-05-14T11:11:40Z

@@ -8,6 +8,7 @@ import {conversationCloseEvent} from '../github-helpers/selectors.js';
 import {wrap} from '../helpers/dom-utils.js';


Update play with this file, not readme sandbox#23

Opened

jump-to-conversation-close-event broken on new issues #9455

fregante · 2026-05-14T11:39:43Z

@@ -13,6 +13,7 @@ import {legacyCommentField} from '../github-helpers/selectors.js';
 import {is} from '../helpers/css-selectors.js';


refined-github/sandbox#10

fregante · 2026-05-14T11:40:01Z

@@ -10,6 +10,7 @@ import {$, $closest, $optional} from 'select-dom';
 import features from '../feature-manager.js';


refined-github/sandbox#10

Buttons also shift on hover:

We can either:

Revert this change

Use newer "ButtonGroup" (more LOC)

Indeed, I saw the same issue in the screenshot above:

I think tool-tip does not need to live in the same component, so I wonder if we should just place it a couple of layers up and avoid issues.

I'll try a couple of things

fregante · 2026-05-14T11:40:45Z

@@ -1 +1 @@
 import './tag-changes-link.css';


https://github.com/refined-github/refined-github/releases

fregante · 2026-05-14T11:56:46Z

@@ -5,6 +5,7 @@ import {lastElementOptional} from 'select-dom';



fregante/bundle#2

fregante · 2026-05-14T11:57:15Z

@@ -1 +1 @@
 import * as pageDetect from 'github-url-detection';


https://github.com/refined-github/refined-github/tree/23.11.15

fregante · 2026-05-14T12:07:12Z

We also should remove now redundant overflow: visible rules like this one: ed3769c/source/features/jump-to-conversation-close-event.css

👌 Done and verified:

Copilot AI and others added 4 commits May 13, 2026 15:43

refactor: replace legacy tooltipped aria-label patterns

10620ca

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/879d9526-be69-4dcd-b9df-5f402298a4b9 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fix: address tooltip migration lint issues

90637d6

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/879d9526-be69-4dcd-b9df-5f402298a4b9 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fix: address validation feedback for tooltip migration

a7b102b

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/879d9526-be69-4dcd-b9df-5f402298a4b9 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

chore: clean up tooltip direction typing

bd741e0

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/879d9526-be69-4dcd-b9df-5f402298a4b9 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot AI assigned Copilot and fregante May 13, 2026

Copilot created this pull request from a session on behalf of fregante May 13, 2026 16:19 View session

fregante requested changes May 13, 2026

View reviewed changes

Copilot started work on behalf of fregante May 13, 2026 16:33 View session

Copilot AI and others added 2 commits May 13, 2026 16:37

fix: address tooltip helper review feedback

6a8d97c

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/548e4a42-b2a9-48bc-9fcc-c14b4d93843f Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fix: apply requested tooltip shortcut and jsx updates

7ee19a6

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/548e4a42-b2a9-48bc-9fcc-c14b4d93843f Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot finished work on behalf of fregante May 13, 2026 16:43

Copilot AI requested a review from fregante May 13, 2026 16:43

Better this way

b89b436

fregante requested changes May 13, 2026

View reviewed changes

Comment thread source/features/one-click-diff-options.tsx Outdated

Comment thread source/features/open-all-notifications.tsx

Comment thread source/features/open-all-notifications.tsx Outdated

Comment thread source/features/quick-review.tsx Outdated

Copilot started work on behalf of fregante May 13, 2026 16:51 View session

fregante mentioned this pull request May 13, 2026

Meta: add tooltipped and addToolTip helpers #9449

Merged

refactor: return tooltipped as single JSX fragment

7771c7e

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/34ab5d27-c768-4348-9f21-e8b1f67a7d17 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot AI changed the title ~~Refactor tooltip usage to helper APIs~~ Refactor tooltip usage to helper APIs and single-fragment tooltipped May 13, 2026

Copilot finished work on behalf of fregante May 13, 2026 17:00

Copilot AI requested a review from fregante May 13, 2026 17:00

fregante added 2 commits May 14, 2026 00:07

Discard changes to source/features/one-click-review-submission.tsx

f1e1c16

Discard changes to source/features/unreleased-commits.tsx

0e7e4fb

fregante requested changes May 13, 2026

View reviewed changes

Comment thread eslint-rules/restricted-syntax.js

Comment thread source/features/default-branch-button.tsx Outdated

Comment thread source/features/quick-review.tsx Outdated

Copilot started work on behalf of fregante May 13, 2026 17:12 View session

fregante and others added 3 commits May 14, 2026 00:12

Update pr-commit-lines-changed.tsx

ae18eea

Merge remote-tracking branch 'origin/main' into copilot/replace-aria-…

cad5613

…label-with-tooltip

fix: apply follow-up lint and review refinements

fdba006

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/b1af5a61-e585-4947-af3f-dc6d7c219c5d Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot AI changed the title ~~Refactor tooltip usage to helper APIs and single-fragment tooltipped~~ Refactor tooltip usage to helper APIs, single-fragment tooltipped, and hotkey-tooltip linting May 13, 2026

Copilot finished work on behalf of fregante May 13, 2026 17:18

Copilot AI requested a review from fregante May 13, 2026 17:18

fregante added 4 commits May 14, 2026 00:21

Discard changes to source/features/releases-tab.tsx

8d86ee6

Discard changes to source/github-helpers/hotkey.tsx

687253b

Discard changes to source/github-helpers/hotkey.tsx

31506fc

Discard changes to source/features/select-notifications.tsx

538d894

fregante requested changes May 13, 2026

View reviewed changes

Comment thread source/features/open-all-notifications.tsx Outdated

Comment thread source/features/open-all-notifications.tsx Outdated

Copilot started work on behalf of fregante May 13, 2026 17:25 View session

refactor: simplify open-all-notifications tooltip insertion

4d76a37

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/896f2162-0331-43d8-8a4d-46a727db5113 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot finished work on behalf of fregante May 13, 2026 17:29

Copilot AI requested a review from fregante May 13, 2026 17:29

fregante changed the title ~~Refactor tooltip usage to helper APIs, single-fragment tooltipped, and hotkey-tooltip linting~~ Update tooltips style May 13, 2026

fregante added the enhancement label May 13, 2026

fregante changed the title ~~Update tooltips style~~ Update tooltips style to integrate better May 13, 2026

fregante marked this pull request as ready for review May 13, 2026 17:40

fregante approved these changes May 13, 2026

View reviewed changes

fregante added 2 commits May 14, 2026 17:59

Merge remote-tracking branch 'origin/main' into copilot/replace-aria-…

aa571c0

…label-with-tooltip

Discard changes to source/features/close-as-unplanned.tsx

a1ec1c3

fregante approved these changes May 14, 2026

View reviewed changes

Review comment

a0f7b3b

fregante enabled auto-merge (squash) May 14, 2026 12:07

Update features-meta.json

0f4539a

fregante merged commit 2abb5bd into main May 14, 2026
9 checks passed

fregante deleted the copilot/replace-aria-label-with-tooltip branch May 14, 2026 12:17

This was referenced May 16, 2026

Fix tooltipped grouped buttons borders #9482

Merged

visit-tag - Fix misalignment #9520

Merged

		@@ -10,6 +10,7 @@ import api from '../github-helpers/api.js';
		import {expectToken} from '../github-helpers/github-token.js';

		@@ -15,6 +15,7 @@ import {fixFileHeaderOverlap, isRepoCommitListRoot} from '../github-helpers/inde
		import isDefaultBranch from '../github-helpers/is-default-branch.js';

		@@ -11,6 +11,7 @@ import {expectToken} from '../github-helpers/github-token.js';
		import {cacheByRepo} from '../github-helpers/index.js';

		@@ -10,6 +10,7 @@ import {$, $$, $$optional, $closest, $optional} from 'select-dom';
		import features from '../feature-manager.js';

		@@ -8,6 +8,7 @@ import {conversationCloseEvent} from '../github-helpers/selectors.js';
		import {wrap} from '../helpers/dom-utils.js';

		@@ -13,6 +13,7 @@ import {legacyCommentField} from '../github-helpers/selectors.js';
		import {is} from '../helpers/css-selectors.js';

		@@ -10,6 +10,7 @@ import {$, $closest, $optional} from 'select-dom';
		import features from '../feature-manager.js';

		@@ -5,6 +5,7 @@ import {lastElementOptional} from 'select-dom';

		@@ -1 +1 @@
		import * as pageDetect from 'github-url-detection';

Uh oh!

Conversation

Copilot AI commented May 13, 2026 • edited by fregante Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fregante May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fregante commented May 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

Copilot AI commented May 13, 2026 •

edited by fregante

Loading

SunsetTechuila commented May 13, 2026 •

edited

Loading

fregante left a comment •

edited

Loading

fregante May 14, 2026 •

edited

Loading