Skip to content

Fix showToast not displaying error message #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Draft

Fix showToast not displaying error message #9473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/github-helpers/toast.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ export default async function showToast(
};

const finalUpdateToast = async (message: ToastMessage): Promise<void> => {
updateToast(message);

// Without rAF the toast might be removed before the first page paint
// rAF also allows showToast to resolve as soon as task is done
await frame();
Expand Down Expand Up @@ -95,6 +93,8 @@ export default async function showToast(
throw error;
} finally {
// Use the last message if `false` was passed
void finalUpdateToast(finalToastMessage || lastRawMessage);
const toastMessage = finalToastMessage || lastRawMessage;
updateToast(toastMessage);
void finalUpdateToast(toastMessage);
}
}