Fix showToast not displaying error message#9473
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/0b9ac115-d8a9-412e-abc8-1e3f56e1d3d0 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
fregante
May 15, 2026 18:51
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
showToastwas turning red on errors but not showing the error message text.Root Cause
updateToast()— the function that updates the message text in the DOM — was called only as the first statement offinalUpdateToast(), an async function invoked fire-and-forget viavoidin thefinallyblock:When
throw erroris pending from the catch block, the DOM update initiated inside the fire-and-forget async task can fail to render before the error propagates and the caller's code runs. In browser extension environments particularly, this means the message wrapper gets cleared (bymessageWrapper.textContent = '') but never repopulated.Fix
Move
updateToast()out offinalUpdateToast()and call it synchronously in thefinallyblock before starting the async animation work:This guarantees the message wrapper is always updated synchronously during
finallyexecution, regardless of error propagation behavior.