Meta: use and prefer `$closest` from `select-dom` by Copilot · Pull Request #9325 · refined-github/refined-github

Copilot · 2026-05-01T10:15:47Z

Upgrades select-dom to v10 and migrates all .closest() and .querySelector() calls to the new $closest/$closestOptional/$() API.

Rules:

element.closest(sel)! → $closest(sel, element)
element.closest(sel) / ?.closest() → $closestOptional(sel, element)
element.querySelector(sel)! → $(sel, element)

ESLint rule (`eslint-rules/select-dom.js`)

Added auto-fix handler for element.closest(sel) — detects TSNonNullExpression parent to pick $closest vs $closestOptional

ESLint config (`eslint.config.js`)

Added $closest and $closestOptional to the array-with-comments and single-element-array selectors
Removed [callee.property.name=closest] (no longer needed)
New lint rule: TSNonNullExpression > CallExpression > [name=$closest] — flags unnecessary ! since $closest already throws

Source migration (~70 files)

All .closest() calls replaced via eslint --fix
Remaining .querySelector() calls on $closest(...) results replaced with $() in action-pr-link, comments-time-machine-links, quick-file-edit, release-download-count, restore-file, status-subscription, options/feature-list
select-dom imports updated in every affected file
cross-deleted-pr-branches: added explicit !lastBranchAction guard before $closest call to avoid throwing when the element is absent
dom-formatters: removed now-unnecessary String() wrapper — $closestOptional accepts readonly string[] directly in v10
one-click-review-submission: inlined legacyActionsRow intermediate variable to a single line
prevent-link-loss: wrapped multi-selector array onto multiple lines for readability
actionable-pr-view-file: merged with main's refactor (new handleMenuOpening/isDeletedFile/getFilePath), updated remaining .closest() calls to $closest; import expanded to multi-line by formatter
batch-mark-files-as-viewed: merged with main's handleClick routing structure, updated all three .closest(fileSelector)! calls (remember, batchToggle, onAltClick) to $closest

Test fix (`test/setup-file.js`)

Added Element to the linkedom globals so $closestOptional's instanceof Element check works correctly in the Vitest environment

Test URLs

Screenshot

…sestOptional Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/7d4877cc-7fc6-4b13-8d54-0c9bdba31918 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fregante

In some comments I mentioned using $(). I'm referring to replacing querySelector

…remove String() wrapper Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/f5656b6b-dc1b-4934-a413-dd87e3c67879 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fregante · 2026-05-01T10:40:00Z

-	const fileLink = fileIcon
-		.closest('.react-directory-filename-column')!
-		.querySelector('a.Link--primary')!;
+	const fileLink = $('a.Link--primary', $closest('.react-directory-filename-column', fileIcon));


Unfortunate readability downgrade, but now we get better errors 🥲

…ple lines Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/6ea377f0-4edd-4fcd-92da-500446f40af5 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fregante · 2026-05-01T10:50:22Z

@copilot Vitest is failing

…ional instanceof check Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/00b45907-aff2-4d0b-92ab-e05740b7736a Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot · 2026-05-01T10:53:10Z

@copilot Vitest is failing

Fixed in 2f04abb. select-dom v10's $closestOptional does baseElement instanceof Element, but the test environment (linkedom) doesn't set Element as a global. Added 'Element' to the globals list in test/setup-file.js — all 5 tests in shorten-link.test.ts now pass.

fregante

I might be biased but I think this is fantastic. Virtually every .closest() call we had was followed by !, so this addresses a real issue.

There are 3/4 instances of reduces readability like:

event
  .delegateTarget
  .closest('div')
  .querySelector('a')

becoming:

$('a', $closest('div', event.delegateTarget))

but we could either accept it or revert it (in the future, if we think it's bad and not just "a bad change")

We could also wrap it this way to retain some readability, but it only works if the selectors are long

$(
  'a.Link--primary',
  $closest(
    '.react-directory-filename-column',
    event.delegateTarget
  ),
)

SunsetTechuila · 2026-05-01T11:38:32Z

$ could return an extended instance of Element with the $closest method: $('a').$closest('div')

fregante · 2026-05-01T11:58:33Z

$ could return an extended instance of Element with the $closest method: $('a').$closest('div')

I don't want to reinvent jQuery. I've gone back and forth on this kind of magic and I've settled on simple independent functions. See also:

Flip order of arguments fregante/select-dom#41

fregante · 2026-05-01T12:05:36Z

See also my other attempts at similar magic:

It only supports methods sindresorhus/magic-iterable#4

fregante · 2026-05-01T12:23:42Z

I'll merge this after the release

…-dom-to-v10 # Conflicts: # source/features/actionable-pr-view-file.tsx # source/features/batch-mark-files-as-viewed.tsx Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/eb7aeef7-2e6a-4056-b82a-c6b9e995fb8d Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

fregante

Will merge after 26.5.1

fregante · 2026-05-01T21:07:59Z

@copilot run "npm run fix"

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/79f2b890-993d-4334-bab0-de4d6c308e5d Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot · 2026-05-01T21:10:23Z

@copilot run "npm run fix"

Done in b4c07ce. The only change was a formatting fix in actionable-pr-view-file.tsx — the single-line select-dom import was expanded to multi-line. The vitest failures reported by the script are pre-existing (selectors + event-listener-loop tests failing due to GitHub UI changes), not related to this PR.

feat: update select-dom to v10, replace .closest() with $closest/$clo…

56e307c

…sestOptional Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/7d4877cc-7fc6-4b13-8d54-0c9bdba31918 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot AI assigned Copilot and fregante May 1, 2026

Copilot created this pull request from a session on behalf of fregante May 1, 2026 10:15

View session

fregante changed the title ~~Update select-dom to v10, replace .closest() with $closest/$closestOptional~~ Meta: use and prefer $closest from select-dom May 1, 2026

fregante requested changes May 1, 2026

View reviewed changes

Copilot started work on behalf of fregante May 1, 2026 10:31

View session

fix: replace remaining .querySelector() with $(), fix closest guard, …

c8939e8

…remove String() wrapper Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/f5656b6b-dc1b-4934-a413-dd87e3c67879 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot finished work on behalf of fregante May 1, 2026 10:37

Copilot AI requested a review from fregante May 1, 2026 10:37

fregante requested changes May 1, 2026

View reviewed changes

Copilot started work on behalf of fregante May 1, 2026 10:41

View session

fix: one-line legacyActionsRow, wrap prevent-link-loss array on multi…

168a2d6

…ple lines Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/6ea377f0-4edd-4fcd-92da-500446f40af5 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot finished work on behalf of fregante May 1, 2026 10:43

Copilot AI requested a review from fregante May 1, 2026 10:43

fregante marked this pull request as ready for review May 1, 2026 10:49

Copilot started work on behalf of fregante May 1, 2026 10:50

View session

fix: add Element to linkedom globals in test setup to fix $closestOpt…

2f04abb

…ional instanceof check Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/00b45907-aff2-4d0b-92ab-e05740b7736a Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot finished work on behalf of fregante May 1, 2026 10:53

fregante approved these changes May 1, 2026

View reviewed changes

fregante added the meta Related to Refined GitHub itself label May 1, 2026

fregante marked this pull request as draft May 1, 2026 12:23

fregante marked this pull request as ready for review May 1, 2026 16:30

Copilot started work on behalf of fregante May 1, 2026 16:30

View session

Merge remote-tracking branch 'origin/main' into copilot/update-select…

3ccc3e0

…-dom-to-v10 # Conflicts: # source/features/actionable-pr-view-file.tsx # source/features/batch-mark-files-as-viewed.tsx Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

This comment was marked as resolved.

Sign in to view

Copilot finished work on behalf of fregante May 1, 2026 16:36

Copilot AI requested a review from fregante May 1, 2026 16:36

Discard changes to source/features/batch-mark-files-as-viewed.tsx

2ae624e

Copilot started work on behalf of fregante May 1, 2026 16:41

View session

fix: restore $closest migration in batch-mark-files-as-viewed.tsx

538a56e

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/eb7aeef7-2e6a-4056-b82a-c6b9e995fb8d Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot finished work on behalf of fregante May 1, 2026 16:44

fregante approved these changes May 1, 2026

View reviewed changes

Copilot started work on behalf of fregante May 1, 2026 21:08

View session

style: run npm run fix (format import in actionable-pr-view-file.tsx)

b4c07ce

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/79f2b890-993d-4334-bab0-de4d6c308e5d Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot finished work on behalf of fregante May 1, 2026 21:11

Copilot AI requested a review from fregante May 1, 2026 21:11

Merge branch 'main' into copilot/update-select-dom-to-v10

f2b4aa0

fregante merged commit d14d4eb into main May 2, 2026
10 checks passed

fregante deleted the copilot/update-select-dom-to-v10 branch May 2, 2026 11:24

SunsetTechuila mentioned this pull request May 6, 2026

quick-mention - Restore feature on issues #9352

Merged

This was referenced May 7, 2026

conversation-activity-filter - Also hide bot comments #9361

Merged

(duplicate) #9374

Closed

conversation-activity-filter doesn't hide resolved reviews #9375

Closed

fregante mentioned this pull request May 19, 2026

conversation-activity-filter - Hide resolved review threads #9527

Merged

Conversation

Copilot AI commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint rule (eslint-rules/select-dom.js)

ESLint config (eslint.config.js)

Source migration (~70 files)

Test fix (test/setup-file.js)

Test URLs

Screenshot

Uh oh!

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fregante May 1, 2026

Choose a reason for hiding this comment

Uh oh!

fregante commented May 1, 2026

Uh oh!

Copilot AI commented May 1, 2026

Uh oh!

fregante left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented May 1, 2026

Uh oh!

fregante commented May 1, 2026

Uh oh!

fregante commented May 1, 2026

Uh oh!

This comment was marked as resolved.

fregante left a comment

Choose a reason for hiding this comment

Uh oh!

fregante commented May 1, 2026

Uh oh!

Copilot AI commented May 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 1, 2026 •

edited

Loading

ESLint rule (`eslint-rules/select-dom.js`)

ESLint config (`eslint.config.js`)

Test fix (`test/setup-file.js`)

fregante left a comment •

edited

Loading

SunsetTechuila commented May 1, 2026 •

edited

Loading