Skip to content

Detect and avoid 404 and 500 error pages #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 1 commit into from
Dec 20, 2017
Merged

Detect and avoid 404 and 500 error pages #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions source/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ window.select = select;

async function init() {
await safeElementReady('body');
if (pageDetect.is404() || pageDetect.is500()) {
return;
}
if (document.body.classList.contains('logged-out')) {
return;
}
Expand Down
4 changes: 3 additions & 1 deletion source/libs/page-detect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ export const getOwnerAndRepo = () => {
return {ownerName, repoName};
};

export const is404 = () => document.title.startsWith('Page not found');
export const is404 = () => document.title === 'Page not found · GitHub';

export const is500 = () => document.title === 'Server Error · GitHub';

export const isBlame = () => /^blame\//.test(getRepoPath());

Expand Down
19 changes: 18 additions & 1 deletion test/page-detect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,31 @@ test('getOwnerAndRepo', t => {
});

test('is404', t => {
document.title = 'Page not found • GitHub';
document.title = 'Page not found · GitHub';
t.true(pageDetect.is404());

document.title = 'examples/404: Page not found examples';
t.false(pageDetect.is404());

document.title = 'Dashboard';
t.false(pageDetect.is404());

document.title = 'Page not found · Issue #266 · sintaxi/surge · GitHub';
t.false(pageDetect.is404());
});

test('is500', t => {
document.title = 'Server Error · GitHub';
t.true(pageDetect.is500());

document.title = 'examples/500: Server Error examples';
t.false(pageDetect.is500());

document.title = 'Dashboard';
t.false(pageDetect.is500());

document.title = 'Server Error · Issue #266 · sintaxi/surge · GitHub';
t.false(pageDetect.is500());
});

test('isBlame', urlMatcherMacro, pageDetect.isBlame, [
Expand Down